-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo fixes for src/vs/workbench/parts #555
Conversation
Hi @gluck, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
@@ -325,7 +325,7 @@ export class DebugEditorModelManager implements wbext.IWorkbenchContribution { | |||
|
|||
private static FOCUSED_STACK_FRAME_DECORATION: editorcommon.IModelDecorationOptions = { | |||
isWholeLine: true, | |||
className: 'debug-focussed-stack-frame-line', | |||
className: 'debug-focused-stack-frame-line', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you adopt the same change on src/vs/workbench/parts/debug/browser/media/debug.contribution.css
where this class name is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, done ! I will check the other PR in case I missed css modifications as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(looks good, note that I didn't check for uses/typos outside of these 2 folders, let me know if you notice potential impact)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks OK to me. Let's just wait for the builds to go green, and I'll merge it right after. Thanks for this! 👍
Hi @gluck, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Once again, sorry for the spam. |
Typo fixes for src/vs/workbench/parts
🎆 |
No description provided.