Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fixes for src/vs/workbench/parts #555

Merged
merged 3 commits into from
Nov 25, 2015
Merged

Conversation

gluck
Copy link
Contributor

@gluck gluck commented Nov 24, 2015

No description provided.

@msftclas
Copy link

Hi @gluck, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@joaomoreno joaomoreno self-assigned this Nov 25, 2015
@@ -325,7 +325,7 @@ export class DebugEditorModelManager implements wbext.IWorkbenchContribution {

private static FOCUSED_STACK_FRAME_DECORATION: editorcommon.IModelDecorationOptions = {
isWholeLine: true,
className: 'debug-focussed-stack-frame-line',
className: 'debug-focused-stack-frame-line',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure you adopt the same change on src/vs/workbench/parts/debug/browser/media/debug.contribution.css where this class name is used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, done ! I will check the other PR in case I missed css modifications as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(looks good, note that I didn't check for uses/typos outside of these 2 folders, let me know if you notice potential impact)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks OK to me. Let's just wait for the builds to go green, and I'll merge it right after. Thanks for this! 👍

@joaomoreno joaomoreno closed this Nov 25, 2015
@joaomoreno joaomoreno reopened this Nov 25, 2015
@msftclas
Copy link

Hi @gluck, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@joaomoreno
Copy link
Member

Once again, sorry for the spam.

joaomoreno added a commit that referenced this pull request Nov 25, 2015
Typo fixes for src/vs/workbench/parts
@joaomoreno joaomoreno merged commit 9870484 into microsoft:master Nov 25, 2015
@joaomoreno
Copy link
Member

🎆

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants