Use npm view to populate info box #56040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, that looks like a good approach. That's surely a good approach for the hover. However, I'm not sure if the performance is still good enough for code completion. |
|
@aeschli what can we do to progress here? Also looking for that feature. |
|
@jk21 The PR is good, but only covers the hovers. There are also the code completions and it would be great if we have a solution to use |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: 54248
Switch to using
npm viewinstead of hitting the public registry. This allows for info to be populated for packages coming out of private registries assuming the user's .npmrc files are setup accordingly.Wondering if this approach is what you had in mind @aeschli ? If so, I could try and tackle the rest of the file.