Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #46123 : Remove absolute path for python #56943

Merged
merged 1 commit into from Sep 13, 2018

Conversation

jatinsandilya
Copy link
Contributor

Fixes #46123

@joaomoreno
Copy link
Member

@jats22 Did you confirm that that snippet of python code runs on any python version 2 and 3?

@joaomoreno joaomoreno added this to the Backlog milestone Aug 22, 2018
@joaomoreno joaomoreno added macos Issues with VS Code on MAC/OS X workbench-os-integration Native OS integration issues labels Aug 22, 2018
@jatinsandilya
Copy link
Contributor Author

@joaomoreno I tested that line of python code in version 2.7 & 3 and got the same result. And as per https://docs.python.org/3/whatsnew/3.0.html I understand that the print as a function is backpropagated into 2.6 as well.

pythonout

Am I missing something?
Also I am not sure as though how this script is used in the project however. Any pointers?

@joaomoreno
Copy link
Member

On macOS, there's a global command Shell Command: Install 'code' command in PATH. This will allow users to simply run code globally. This shell script is what runs in that scenario.

@jatinsandilya
Copy link
Contributor Author

Ahh. I see. Thanks!

@joaomoreno joaomoreno modified the milestones: Backlog, September 2018 Sep 13, 2018
@joaomoreno joaomoreno merged commit a5c6208 into microsoft:master Sep 13, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Sep 13, 2018

Thanks! 🍻

@jatinsandilya jatinsandilya deleted the 46123 branch September 13, 2018 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
macos Issues with VS Code on MAC/OS X workbench-os-integration Native OS integration issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vscode edit bug report
2 participants