improve handling fallback of theme colors in terminal #57100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #57038
@Tyriar
Yet to change defaults for
TERMINAL_BORDER_COLOR
.I am not able to relate it to any appropriate editor colors (though there are
editorWidgetBorder
,editorHoverBorder
, etc).Should I consider hard-coding the defaults same as
PANEL_BORDER
?https://github.com/Microsoft/vscode/blob/07618102efdd63f09949ce54c161e7fd2a954ee8/src/vs/workbench/common/theme.ts#L184-L188