Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #57222 - improve no user.email/user.name config error message #58174

Merged
merged 3 commits into from
Sep 13, 2018

Conversation

Git-Lior
Copy link
Contributor

@Git-Lior Git-Lior commented Sep 7, 2018

The new message looks like this:

image

Tell me if anything can be improved. Thanks!

@dzienisz
Copy link

dzienisz commented Sep 7, 2018

Is there a possibility to show current email and name config?

@msftclas
Copy link

msftclas commented Sep 7, 2018

CLA assistant check
All CLA requirements met.

@Git-Lior
Copy link
Contributor Author

Git-Lior commented Sep 7, 2018

Now the error message looks like this:

image

@dzienisz is this better?

@dzienisz
Copy link

dzienisz commented Sep 7, 2018

@Git-Lior I think so. Thanks!

@kevinji
Copy link
Contributor

kevinji commented Sep 8, 2018

For consistency, maybe flip the two current lines so email comes first and name comes second?

@Git-Lior
Copy link
Contributor Author

Git-Lior commented Sep 8, 2018

@mc10 you're correct, done 👍

@joaomoreno joaomoreno added this to the Backlog milestone Sep 10, 2018
@joaomoreno joaomoreno added the git GIT issues label Sep 10, 2018
@joaomoreno joaomoreno merged commit 8d147f3 into microsoft:master Sep 13, 2018
@joaomoreno joaomoreno modified the milestones: Backlog, September 2018 Sep 13, 2018
@joaomoreno
Copy link
Member

Thanks! 🍻

@Git-Lior Git-Lior deleted the git-missing-user-info branch September 13, 2018 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
git GIT issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants