Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to make the EH debugging to work when live share proxy the debug adapter #58227

Closed
wants to merge 1 commit into from

Conversation

rodrigovaras
Copy link
Contributor

A recent change on vscode stop 'injecting' the '__sessionI' property for all resolved configurations except the EH debugging type. vscode will always see the type as 'vslsShare' insted of 'extensionHost' type.
The changes will identify such cases and inspect the debug configuration looking for the proper debug type.

… configuration was resolved by the extension
@rodrigovaras
Copy link
Contributor Author

@weinand, can you take a look to this?

@weinand
Copy link
Contributor

weinand commented Sep 7, 2018

Thanks for the PR.
I have centralized the EH check into one place.

@weinand weinand closed this Sep 7, 2018
@weinand weinand added this to the September 2018 milestone Sep 7, 2018
@weinand weinand self-assigned this Sep 7, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants