Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Electron to 2.0.9 #58382

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Update Electron to 2.0.9 #58382

merged 1 commit into from
Sep 11, 2018

Conversation

mfonville
Copy link
Contributor

@mfonville mfonville commented Sep 10, 2018 •
edited
Loading

As described in #57457

Fixes the glibc 2.28 problem, includes the other fixes that @bpasero was waiting for

@msftclas
Copy link

msftclas commented Sep 10, 2018 •
edited
Loading

CLA assistant check
All CLA requirements met.

bpasero
bpasero requested changes Sep 11, 2018
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a reference in the package.json of the smoke test (just search for 2.0.7)

@bpasero bpasero added this to the September 2018 milestone Sep 11, 2018
@bpasero bpasero self-assigned this Sep 11, 2018
@mfonville
Copy link
Contributor Author

Thanks, I amended the commit for the PR

@bpasero
Copy link
Member

bpasero commented Sep 11, 2018

@mfonville thanks, I think you need to run a yarn install in the smoke test to get the yarn.lock file also updated.

@mfonville
Copy link
Contributor Author

Ok, I also updated the lock file

@bpasero bpasero merged commit 2ba2fa5 into microsoft:master Sep 11, 2018
@bpasero
Copy link
Member

bpasero commented Sep 11, 2018

Thanks!

@shizonic shizonic mentioned this pull request Sep 22, 2018
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpasero bpasero bpasero requested changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
September 2018
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mfonville @msftclas @bpasero