Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing access keys (mnemonics) for menu items #58412

Merged
merged 2 commits into from
Sep 11, 2018
Merged

Add missing access keys (mnemonics) for menu items #58412

merged 2 commits into from
Sep 11, 2018

Conversation

rik-smeets
Copy link
Contributor

Add missing access keys (mnemonics) for:

  • Update menu items (i.e. Restart to Update etc.)
  • Add Configuration
  • Enable All Breakpoints
  • Auto Save

When I was looking at the improvements done by @sbatten with regards to #54349, I noticed some access keys were missing. I added those in this pull request.

@msftclas
Copy link

msftclas commented Sep 11, 2018

CLA assistant check
All CLA requirements met.

…uration, Enable All Breakpoints and Auto Save
@sbatten sbatten added this to the September 2018 milestone Sep 11, 2018
@sbatten sbatten self-requested a review September 11, 2018 18:15
@sbatten
Copy link
Member

sbatten commented Sep 11, 2018

Thanks @rik-smeets, I've added the mnemonics to the native menu system for consistency.

@sbatten sbatten merged commit 7bca3fb into microsoft:master Sep 11, 2018
@rik-smeets rik-smeets deleted the add-missing-access-keys branch September 11, 2018 18:46
@joaosamouco
Copy link

I believe this change is causing issues on the most recent Code Insiders (Version 1.28.0-insider (1.28.0-insider).

screen shot 2018-09-13 at 13 00 46

As you can see, some & is being displayed on Check for Updates option. This is also occuring in other Menu Options.

@joaosamouco joaosamouco mentioned this pull request Sep 13, 2018
@rik-smeets
Copy link
Contributor Author

@joaosamouco I think so too, see #58603 for my quick analysis.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants