Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot focus on NPM Scripts in Explorer via keyboard #58469

Closed
markboisvert opened this issue Sep 12, 2018 · 6 comments
Closed

Cannot focus on NPM Scripts in Explorer via keyboard #58469

markboisvert opened this issue Sep 12, 2018 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality tree-views Extension tree view issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@markboisvert
Copy link

  • VSCode Version: 1.27.1
  • OS Version: Ubuntu 18.04.1 LTS (bionic)

Steps to Reproduce:

  1. Edit Settings -> Enable explorer view for NPM Scripts
  2. Try to access NPM Scripts in Explorer via keyboard

NOTE: There is no "Focus on NPM Scripts View" command, but the following commands are available:

  • Focus on Open Editors View
  • Focus on Files Explorer
  • Focus on Outline

Does this issue occur when all extensions are disabled?: Yes

@bpasero bpasero assigned sandy081 and unassigned bpasero Sep 12, 2018
@sandy081
Copy link
Member

@Marbois There are no individual commands for each view. There is a general command Open View from which you can open the view.

Such a view specific command should come from the custom view extension.

@sandy081 sandy081 assigned egamma and unassigned sandy081 Sep 12, 2018
@egamma egamma added the feature-request Request for new features or functionality label Sep 14, 2018
@egamma
Copy link
Member

egamma commented Sep 14, 2018

@Marbois the Open View command can be used to focus the NPM script explorer using the keyboard. One view is CMP + P and then typing ´view npm´. So I´ll label this as a feature request.

@egamma
Copy link
Member

egamma commented Sep 14, 2018

@sandy081 I´ve looked into providing a Focus NPM Script Explorer command. However, I didn´t find an API for the TreeView to change the focus. Did I overlook something?

@sandy081
Copy link
Member

@egamma No, you are right there is no API support to focus or open a view. There are two approaches

  1. Core can create commands Focus: ${view_name} for all views where all extensions can get this feature for free

  2. Expose an API / command to focus / open the view and extension can contribute the command.

I think first approach is preferable. What do you think?

@egamma egamma assigned sandy081 and unassigned egamma Sep 17, 2018
@sandy081 sandy081 added the tree-views Extension tree view issues label Sep 17, 2018
@sandy081 sandy081 added this to the Backlog milestone Sep 17, 2018
@sandy081 sandy081 modified the milestones: Backlog, September 2018 Sep 21, 2018
@sandy081
Copy link
Member

sandy081 commented Sep 24, 2018

Verify that there are commands to focus all views (including custom) in the side bar

@sandy081 sandy081 added the verification-needed Verification of issue is requested label Sep 24, 2018
@mjbvz mjbvz added the verified Verification succeeded label Sep 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality tree-views Extension tree view issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants