Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: restart shuold also resolve configuration by providers when changed #59819

Merged
merged 1 commit into from Oct 2, 2018

Conversation

isidorn
Copy link
Contributor

@isidorn isidorn commented Oct 2, 2018

fixes #59795

This fixes the issue introduced by a debug restart refactoring that the configurations are no longer resolved by debug proivders on restart.
Previously on restart we were calling the monster startDebugging which would do everything and now we are trying to do just what is needed on the restart. However on a refactoring I forgot to resolve configuration by providers.

@isidorn isidorn added this to the September 2018 milestone Oct 2, 2018
@isidorn isidorn self-assigned this Oct 2, 2018
@isidorn isidorn merged commit 60db21f into release/1.28 Oct 2, 2018
@isidorn isidorn deleted the isidorn/debugRestartResolve branch October 2, 2018 10:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants