Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command 'workbench.action.editorLayoutCentered' not found #62984

Closed
davidpope opened this issue Nov 13, 2018 · 5 comments · Fixed by #63328
Closed

command 'workbench.action.editorLayoutCentered' not found #62984

davidpope opened this issue Nov 13, 2018 · 5 comments · Fixed by #63328
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@davidpope
Copy link

  • VSCode Version: 1.29.0
  • OS Version: Linux - Xubuntu 18.10

Steps to Reproduce:

  1. Click View -> Editor Layout -> Centered

Does this issue occur when all extensions are disabled?: Yes

Expected behavior: The view switches to centered layout.
Actual behavior: Error message displayed

image

Supporting data: There's only one key-bindable command with 'centered' in its text, Toggle Centered Layout:

image

@vscodebot
Copy link

vscodebot bot commented Nov 13, 2018

@roblourens roblourens added the candidate Issue identified as probable candidate for fixing in the next release label Nov 13, 2018
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Nov 13, 2018
@isidorn isidorn added this to the October 2018 Recovery milestone Nov 13, 2018
@mjbvz mjbvz added the verified Verification succeeded label Nov 16, 2018
@dpope-atlassian
Copy link

I see an attempted fix in 1.29.1, but it still does not behave as expected.

  1. Start from Single layout.
  2. Choose View -> Editor Layout -> Centered
  3. Choose View -> Editor Layout -> Single

Expected behavior: Single layout is selected.
Actual behavior: Nothing happens.

In order to get Single layout back, you have to choose View -> Editor Layout -> Centered again. It's as though the menu item invokes the Toggle Centered Layout command, which isn't expected.

It also breaks, but differently, when transitioning from other layouts:

  1. Start from Single layout.
  2. Choose View -> Editor Layout -> Two Columns
  3. Choose View -> Editor Layout -> Centered

Expected behavior: Centered layout is selected
Actual behavior: Nothing happens.

You have to go back to Single layout first in order for Centered to work.

@Nemesis19
Copy link

Version 1.29.1 on macOS
View -> Editor Layout -> Centered it works well.
To disable it I need to do again View -> Editor Layout -> Centered instead of selecting View -> Editor Layout -> Single that in that case does nothing

@niedzielski
Copy link

Issue occurred in one workspace on v1.29.0 (Ubuntu). Issue fixed in v1.29.1.

@sbatten sbatten reopened this Nov 16, 2018
@sbatten sbatten removed candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded labels Nov 16, 2018
@sbatten
Copy link
Member

sbatten commented Nov 16, 2018

@isidorn This is actually a duplicated entry in the menu. It exists as Toggle Centered Layout in Appearance and Centered in Editor Layout. Our old menu bar never had this second entry so I believe it should be removed. The rest of the entries in the Editor Layout menu do not toggle but set the layout directly.

@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants