Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove centered layout from layout menu #63328

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Conversation

sbatten
Copy link
Member

@sbatten sbatten commented Nov 16, 2018

fixes #62984

See comment
#62984 (comment)

@sbatten sbatten self-assigned this Nov 16, 2018
@sbatten sbatten requested a review from isidorn November 16, 2018 19:23
@isidorn
Copy link
Contributor

isidorn commented Nov 19, 2018

Thanks for this PR.
I know that @bpasero specificly introduced this action in our layout menu.
It feels to me like it belongs in the layout menu, and not in the Appereance menu - and we should remove it from there. However if we put it in the layout menu than it is not consistent with the other non toggling layouts.
In the apperance menu there is already zen mode which is more general than just layout and is a super set of centered editor layout.

@bpasero @misolori let me know what you think

@bpasero
Copy link
Member

bpasero commented Nov 19, 2018

I am fine removing it from the "Layout" menu because it is a broader thing compared to the other options (and a toggle actually). Strictly speaking, editor layouts are about how to arrange editor groups and the centered editor layout is not doing that, but just changing another layout option.

@isidorn isidorn added this to the November 2018 milestone Nov 19, 2018
@isidorn
Copy link
Contributor

isidorn commented Nov 19, 2018

It also has some automatic resize behavior so it is a bit differnt to other options.
So yeah let's go with the removal in the layout menu. Merging this PR in

@isidorn isidorn merged commit 347216b into microsoft:master Nov 19, 2018
@sbatten sbatten deleted the fix/62984 branch December 7, 2018 22:12
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

command 'workbench.action.editorLayoutCentered' not found
3 participants