Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart select default provider #64004

Closed
4 tasks done
jrieken opened this issue Nov 29, 2018 · 0 comments
Closed
4 tasks done

Smart select default provider #64004

jrieken opened this issue Nov 29, 2018 · 0 comments
Assignees
@jrieken
Labels
feature-request Request for new features or functionality on-testplan release-notes Release notes issues smart-select
Milestone
December/January ...

Comments

@jrieken
Copy link
Member

jrieken commented Nov 29, 2018 •
edited

This is related to #4795. The plan is to delegate computation of selection ranges to extensions (#63935) but for consistent behaviour we should have good default for things that might be outside a typical syntax tree. Such as

  • expand to the current full line (not just a statement) including trivia, the same for the full document
  • expand ranges inside a word following camel-case rules et al
  • expand string literals with/without quotation marks this cannot be done properly with token information
  • simply expansion along bracket pairs
  • expand bracket pairs and leading line contents
@jrieken jrieken self-assigned this Nov 29, 2018
@jrieken jrieken added smart-select feature-request Request for new features or functionality labels Nov 29, 2018
@jrieken jrieken added this to the November 2018 milestone Nov 29, 2018
@jrieken jrieken mentioned this issue Nov 29, 2018
Closed
jrieken added a commit that referenced this issue Nov 30, 2018
@jrieken
add word based provider #64004, add multi-provider merge logic #63935
4b7614f
jrieken added a commit that referenced this issue Dec 3, 2018
@jrieken
smart select bracket pairs, #64004
6938d2c
@jrieken jrieken modified the milestones: November 2018, December 2018 Dec 3, 2018
This was referenced Dec 3, 2018
Closed
Closed
jrieken added a commit that referenced this issue Dec 10, 2018
@jrieken
add leading/trailing line part to bracket selection #64004
3696128
jrieken added a commit that referenced this issue Dec 18, 2018
@jrieken
remove token based string, comment ranges #64004
b4ab23c
jrieken added a commit that referenced this issue Dec 18, 2018
@jrieken
add in word navigation for uppercase characters and underscores, #64004
d6359b2
@jrieken jrieken closed this as completed Dec 18, 2018
@jrieken jrieken mentioned this issue Jan 28, 2019
Closed
1 task
@jrieken jrieken added on-testplan release-notes Release notes issues labels Jan 28, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality on-testplan release-notes Release notes issues smart-select
Projects
None yet
Milestone
December/January 2019
Development

No branches or pull requests
1 participant
@jrieken