Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Click - Either open in Peek or go to definition, not BOTH! #68023

Merged
merged 1 commit into from Feb 8, 2019
Merged

Ctrl+Click - Either open in Peek or go to definition, not BOTH! #68023

merged 1 commit into from Feb 8, 2019

Conversation

DerekZiemba
Copy link
Contributor

The current behavior is if multiple definitions are found, it navigates to the nearest definition and opens peek. Which is super annoying and causes you to loose your place.

  • Use peek if there are multiple definitions
  • When using peek, will not navigate to the best match in editor and cause you to lose your spot
  • If there is only one definition, navigate to best match and NOT open peek

This addresses the following stack overflow complaint and behavior shown in the screencast

https://stackoverflow.com/questions/41460845/disable-peek-in-visual-studio-code/54559763#54559763

vscodeannoying

* Use peek if there are multiple definitions
* When using peek, will not navigate to the best match in editor and cause you to lose your spot
* If there is only one definition, navigate to  best match and NOT open peek
@kieferrm kieferrm requested a review from jrieken February 7, 2019 18:38
@jrieken jrieken added feature-request Request for new features or functionality editor-symbols definitions, declarations, references labels Feb 8, 2019
@jrieken jrieken added this to the February 2019 milestone Feb 8, 2019
@jrieken
Copy link
Member

jrieken commented Feb 8, 2019

thanks.

@nonoroazoro
Copy link

nonoroazoro commented Mar 11, 2019

This change brings inconsistent behaviors of the Go to Definition command, I don't think this PR should be merged, or at least you should give me an option to disable it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-symbols definitions, declarations, references feature-request Request for new features or functionality verification-needed Verification of issue is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants