Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codelens shows "No" occacionally #68290

Closed
rebornix opened this issue Feb 9, 2019 · 6 comments
Closed

Codelens shows "No" occacionally #68290

rebornix opened this issue Feb 9, 2019 · 6 comments
Assignees
@jrieken @mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug code-lens verified Verification succeeded
Milestone
February 2019

Comments

@rebornix
Copy link
Member

rebornix commented Feb 9, 2019

Issue Type: Bug

Very often after swtiching between files I started to see "No" being displayed in Codelens

image

VS Code version: Code - Insiders 1.32.0-insider (709bf35, 2019-02-08T14:51:00.181Z)
OS version: Darwin x64 18.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 4, 4
Memory (System) 16.00GB (1.63GB free)
Process Argv -psn_0_8779871
Screen Reader no
VM 0%
Extensions (45)
Extension Author (truncated) Version
markdown-emoji bie 0.0.7
solargraph cas 0.19.3
npm-intellisense chr 1.3.0
vscode-svgviewer css 1.4.7
vscode-markdownlint Dav 0.23.0
vscode-eslint dba 1.8.0
gitlens eam 9.5.0
remotehub eam 0.2.0
tsl-problem-matcher eam 0.0.4
EditorConfig Edi 0.12.8
tslint eg2 1.0.42
vscode-npm-script eg2 0.3.5
vsc-material-theme Equ 2.6.3
prettier-vscode esb 1.8.1
vscode-pull-request-github-insiders Git 1.39.0
ocaml hac 0.6.43
beautify Hoo 1.4.8
references-plusplus jri 0.0.5
graphql-for-vscode kum 1.13.0
dotenv mik 1.0.1
theme-monokai-pro-vscode mon 1.1.9
vscode-language-pack-zh-hans MS- 1.31.4
python ms- 2019.1.0
azure-account ms- 0.8.0
Go ms- 0.9.1
PowerShell ms- 1.11.0
vscode-typescript-tslint-plugin ms- 0.4.1
wordcount ms- 0.1.0
vsliveshare ms- 0.3.1151
debugger-for-chrome msj 4.11.1
debugger-for-ios-web msj 0.1.2
color-highlight nau 2.3.0
vetur oct 0.15.0
subtitles-editor pep 1.0.2
vscode-versionlens pfl 0.22.0
material-icon-theme PKi 3.6.3
seti-icons qin 0.1.3
project-snippets reb 0.5.0
ruby reb 0.21.0
smartpaste reb 0.0.3
toggle reb 0.0.1
sass-indented rob 1.5.1
rust rus 0.5.3
sourcekit-lsp unp 0.0.1
vscode-lldb vad 1.2.1

(10 theme extensions excluded)
@mjbvz
Copy link
Contributor

mjbvz commented Feb 11, 2019

Duplicate of #68393 I believe

@mjbvz mjbvz closed this as completed Feb 11, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Feb 11, 2019

Nevermind, that's windows only I think. @rebornix are you using the language pack that you have installed?

@mjbvz mjbvz reopened this Feb 11, 2019
@rebornix
Copy link
Member Author

@mjbvz I didn't use any language pack (I have them installed though).

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Feb 11, 2019
@mjbvz mjbvz added this to the February 2019 milestone Feb 11, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Feb 11, 2019

@jrieken I believe this issue may be from 0693cb7. The full text here is no command. We show that placeholder text when resolveCodeLens in extHostLanguageFeatures returns undefined, but I'm having trouble determining why this is happening

@mjbvz
Copy link
Contributor

mjbvz commented Feb 11, 2019

Repo steps

  1. Enable the typescript reference code lens
  2. Open a long file from the VS Code codebase
  3. Wait for lenses to resolve.
  4. Wait 30 seconds or so
  5. Scroll down and then back up to where the previously resolve code lenses were showing
  6. 🐛 Code lenses now labeled as no commands

Looks like the lenses are being garbage collected. I'm trying to figure out why this happens and also why we try to re-resolve already resolved code lenses

@jrieken
Copy link
Member

jrieken commented Feb 12, 2019

Yes, 0693cb7 actually removed a check that prevents double tracking of the same ext-host-side-objects

jrieken added a commit that referenced this issue Feb 12, 2019
@jrieken
don't double create gc signals, #68290
a066fd1
jrieken added a commit that referenced this issue Feb 12, 2019
@jrieken
only resolve lenses that aren't resolved yet, #68290
af24788
@jrieken jrieken closed this as completed Feb 12, 2019
@jrieken jrieken self-assigned this Feb 26, 2019
@roblourens roblourens added the verified Verification succeeded label Feb 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug code-lens verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
4 participants
@roblourens @rebornix @jrieken @mjbvz