Add License field to package.jsons #68423 #68771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisdias Does this make sense? |
LeuisKen
reviewed
Feb 20, 2019
extensions/scss/package.json
Outdated
| @@ -3,7 +3,8 @@ | |||
| "displayName": "%displayName%", | |||
| "description": "%description%", | |||
| "version": "1.0.0", | |||
| "publisher": "vscode", | |||
| "publisher": "vscode", | |||
| "license": "MIT", | |||
There was a problem hiding this comment.
maybe you should use spaces, not tabs.
There was a problem hiding this comment.
updated, thanks for noticing it
it should avoid to have "warning XXX: No license field" during yarn build Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
force-pushed
the
68423-AddLicenseField
branch
from
2848539
to
8142764
Compare
|
: ) |
|
as long as these are all our extensions/sources and we're not adding something to packages we consume, this looks ok to me. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it should avoid to have "warning XXX: No license field" during yarn
build
Signed-off-by: Aurélien Pupier apupier@redhat.com