Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screencast: Some keys do not get special treatment #68849

Closed
vezaynk opened this issue Feb 16, 2019 · 13 comments
Closed

Screencast: Some keys do not get special treatment #68849

vezaynk opened this issue Feb 16, 2019 · 13 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities screencast-mode verified Verification succeeded
Milestone

Comments

@vezaynk
Copy link

vezaynk commented Feb 16, 2019

Currently, if I mash backspace a bunch, this is what happens:

image

However, for arrow keys, it only shows up a single time. This seems unintended and backspace needs to be treated the same way as enter and the arrow keys regardless of how long I press it.

@vscodebot vscodebot bot added the editor-autoindent Editor auto indentation issues label Feb 16, 2019
@bpasero bpasero added screencast-mode and removed editor-autoindent Editor auto indentation issues labels Feb 18, 2019
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities labels Feb 19, 2019
@joaomoreno joaomoreno added this to the Backlog milestone Feb 19, 2019
@joaomoreno joaomoreno changed the title Backspace does not get special treatment Screencast: Some keys do not get special treatment Feb 19, 2019
@joaomoreno
Copy link
Member

Also Escape

@adamtajti
Copy link
Contributor

I was unable to reproduce this at commit e96ab81. Has it been fixed already?
OS: Windows 10 Enterprise N - 1803 (17134.590)

@dyc3
Copy link
Contributor

dyc3 commented Mar 4, 2019

I am able to reproduce this issue and I'd like to fix it. I believe I've found the relevant code in developerActions.ts

@dyc3
Copy link
Contributor

dyc3 commented Mar 5, 2019

@joaomoreno, Would it be better to have counters for the number of times Backspace or Escape is pressed? Or to just display the key once without any counters?

Here what I mean by counters:
vscode-new-screencast-bahavior-with-counters

@joaomoreno
Copy link
Member

I don't think we need counters at all. Wouldn't simply Backspace suffice, no matter how many times you press it?

@dyc3
Copy link
Contributor

dyc3 commented Mar 5, 2019

Yeah, you're right. I'll fix it up and send a pull request.

@adamtajti
Copy link
Contributor

It seems like other screencasting applications have the counter concept as well. I think it might be better to make it configurable.

Carnac (Windows app) seems to have this behavior by default: https://youtu.be/kSL-DhACBEk?t=293

Screencast (Linux app) notes:

Compress repeats
When enabled, contiguous repeated sequences are truncated after the requested threshold. A counter of total occurrences is shown instead, which is generally more legible.

Screenkey (Linux app). It's a configurable setting. Demonstration:
https://youtu.be/OkD0VkGe20I?t=269

@dyc3
Copy link
Contributor

dyc3 commented Mar 5, 2019

That's certainly another option. We could even style the counters so they look different. We'll leave it off by default. How would I go about adding it to the settings?

@dyc3
Copy link
Contributor

dyc3 commented Mar 5, 2019

Also, I think it would be more readable if letters/numbers/symbols didn't have spaces in between them and respected the case they were typed in. What do you guys think?

@adamtajti
Copy link
Contributor

I had the same idea about the spaces and casing too, but I didn't want to go overboard. Maybe the counters were a bit too much for this bug fix as well and it should've been handled in a seperate feature request issue.

I agree with leaving it off by default. I'm trying to figure out how to modify the settings now. I think it should be under the Text Editor > Screencast category or Features > Screencast (they don't exist)

Lets see what @joaomoreno says.

@joaomoreno
Copy link
Member

I really don't have an opinion. We should make the simplest thing possible. I'm not keen on adding settings, since VS Code is not a screencasting tool. ;)

@adamtajti
Copy link
Contributor

I'm not sure if that reasoning stands now that VS Code became a tool that has screencasting capabilities. Although I think we all agree that the focus should be on making the tool better for coding, I think we can make this feature better with the suggested changes and make the most of it. Who knows, maybe this will be a feature that will persue someone on a conference to give VS Code a try :) (I'm thinking about teachers, streamers)

I think that we should create another issue though with the feature-request tags to discuss and track those changes there, while we fix the issue with a single Backspace or Escape output here. I'll have to work now, but I could create the issue later.

Would that work for you @dyc3 ?

@dyc3
Copy link
Contributor

dyc3 commented Mar 6, 2019

Sounds like a plan. I'll send the pull request with the simple fix later today.

@mjbvz mjbvz added the verified Verification succeeded label Aug 27, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities screencast-mode verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants