New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screencast: Some keys do not get special treatment #68849
Comments
Also Escape |
I was unable to reproduce this at commit e96ab81. Has it been fixed already? |
I am able to reproduce this issue and I'd like to fix it. I believe I've found the relevant code in |
@joaomoreno, Would it be better to have counters for the number of times |
I don't think we need counters at all. Wouldn't simply |
Yeah, you're right. I'll fix it up and send a pull request. |
It seems like other screencasting applications have the counter concept as well. I think it might be better to make it configurable. Carnac (Windows app) seems to have this behavior by default: https://youtu.be/kSL-DhACBEk?t=293 Screencast (Linux app) notes:
Screenkey (Linux app). It's a configurable setting. Demonstration: |
That's certainly another option. We could even style the counters so they look different. We'll leave it off by default. How would I go about adding it to the settings? |
Also, I think it would be more readable if letters/numbers/symbols didn't have spaces in between them and respected the case they were typed in. What do you guys think? |
I had the same idea about the spaces and casing too, but I didn't want to go overboard. Maybe the counters were a bit too much for this bug fix as well and it should've been handled in a seperate feature request issue. I agree with leaving it off by default. I'm trying to figure out how to modify the settings now. I think it should be under the Text Editor > Screencast category or Features > Screencast (they don't exist) Lets see what @joaomoreno says. |
I really don't have an opinion. We should make the simplest thing possible. I'm not keen on adding settings, since VS Code is not a screencasting tool. ;) |
I'm not sure if that reasoning stands now that VS Code became a tool that has screencasting capabilities. Although I think we all agree that the focus should be on making the tool better for coding, I think we can make this feature better with the suggested changes and make the most of it. Who knows, maybe this will be a feature that will persue someone on a conference to give VS Code a try :) (I'm thinking about teachers, streamers) I think that we should create another issue though with the feature-request tags to discuss and track those changes there, while we fix the issue with a single Would that work for you @dyc3 ? |
Sounds like a plan. I'll send the pull request with the simple fix later today. |
Currently, if I mash backspace a bunch, this is what happens:
However, for arrow keys, it only shows up a single time. This seems unintended and backspace needs to be treated the same way as enter and the arrow keys regardless of how long I press it.
The text was updated successfully, but these errors were encountered: