Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't pin tabs by double clicking explorer files #69284

Closed
FernandoMiguel opened this issue Feb 23, 2019 · 6 comments
Closed

Can't pin tabs by double clicking explorer files #69284

FernandoMiguel opened this issue Feb 23, 2019 · 6 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues regression Something that used to work is now broken verified Verification succeeded
Milestone
February 2019

Comments

@FernandoMiguel
Copy link

Issue Type: Bug

I used to be able to double click on a file to pin it open, while a single click only temporaly opens the tab

on this build it stop working

VS Code version: Code - Insiders 1.32.0-insider (11416de, 2019-02-23T08:16:36.706Z)
OS version: Darwin x64 18.5.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 4, 4
Memory (System) 16.00GB (0.04GB free)
Process Argv .
Screen Reader no
VM 0%
Extensions (13)
Extension Author (truncated) Version
markdown-toc Ala 1.5.6
spellright ban 3.0.24
vscode-icontheme-nomo-dark be5 1.3.6
better-toml bun 0.3.2
vscode-pull-request-github Git 0.4.0
terraform mau 1.3.7
markdown-shortcuts mdi 0.11.0
prettify-json moh 0.0.3
python ms- 2019.1.0
vscode-docker Pet 0.5.2
vscode-icons rob 8.2.0
vscode-nginx sha 0.6.0
sort-lines Tyr 1.8.0

(2 theme extensions excluded)
@vscodebot
Copy link

vscodebot bot commented Feb 23, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Feb 23, 2019
@Tyriar Tyriar assigned bpasero and unassigned Tyriar Feb 25, 2019
@Tyriar Tyriar removed the terminal Integrated terminal issues label Feb 25, 2019
@bpasero bpasero added file-explorer Explorer widget issues regression Something that used to work is now broken labels Feb 25, 2019
@bpasero bpasero added this to the February 2019 milestone Feb 25, 2019
@bpasero
Copy link
Member

bpasero commented Feb 25, 2019

@isidorn a recent change maybe? I can reproduce.

@bpasero bpasero mentioned this issue Feb 26, 2019
Closed
@isidorn
Copy link
Contributor

isidorn commented Feb 26, 2019

@bpasero I can also reproduce. The issue is that the open event I am getting from the list service has pinned: false, even though it is a double click.
I will do some bisecting to find the fault.
fyi @joaomoreno @sandy081

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Feb 26, 2019
@isidorn
Copy link
Contributor

isidorn commented Feb 26, 2019

By bisection this was broken by 3946e32
If I revert that commit everything works fine.
Forwarding to @joaomoreno

screenshot 2019-02-26 at 11 19 06

@isidorn isidorn assigned joaomoreno and unassigned bpasero and isidorn Feb 26, 2019
@isidorn isidorn mentioned this issue Feb 26, 2019
Closed
@joaomoreno joaomoreno changed the title pinning tabs Can't pin tabs by double clicking explorer files Feb 26, 2019
@FernandoMiguel
Copy link
Author

thanks for looking into this so quickly

@isidorn
Copy link
Contributor

isidorn commented Feb 26, 2019

@FernandoMiguel thanks for using insiders and for reproting issues.

@Ash258 Ash258 mentioned this issue Feb 26, 2019
Closed
@gregvanl gregvanl added the verified Verification succeeded label Feb 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
6 participants
@joaomoreno @FernandoMiguel @bpasero @isidorn @Tyriar @gregvanl