Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open vscode://file/<path> in vscode is broken #69998

Closed
jameschenjav opened this issue Mar 7, 2019 · 4 comments
Closed

Open vscode://file/<path> in vscode is broken #69998

jameschenjav opened this issue Mar 7, 2019 · 4 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded workbench-os-integration Native OS integration issues
Milestone
February 2019 Rec...

Comments

@jameschenjav
Copy link

  • VSCode Version:
    code --version
    1.32.0
    507312a
    x64

  • OS Version:
    macOS High Sierra v10.13.6 (17G3025)

Steps to Reproduce:

  1. In terminal open vscode://file/<my_file_path>
  2. It will popup notification with error Unable to open '<my_file>': resource is not available.

Does this issue occur when all extensions are disabled?: Yes

Since I tried same url just changed vscode to vscodium and VSCodium v1.13.1 works perfectly
@jameschenjav jameschenjav changed the title Open vscode://file/<path> in vscode is broken on mac? Open vscode://file/<path> in vscode is broken on mac after upgraded to 1.32? Mar 8, 2019
@octref octref added the candidate Issue identified as probable candidate for fixing in the next release label Mar 8, 2019
@ije
Copy link

ije commented Mar 10, 2019

i got the same issue...

code --version
1.32.1
05f146c
x64
macOS Mojave 10.14.3

@jrieken jrieken assigned joaomoreno and unassigned jrieken Mar 10, 2019
@bpasero
Copy link
Member

bpasero commented Mar 10, 2019

@joaomoreno I debugged this and I am not 100% sure this is a regression. We end up calling ITextModelResolverService#createModelReference() with the URI vscode://... and this correctly goes into the contribution from preferences:

https://github.com/Microsoft/vscode/blob/22fdb8e2c3efb1c7f8cf0883996044ee5c7b41b1/src/vs/workbench/contrib/preferences/common/preferencesContribution.ts#L110

Which then bails out because the URI is probably not what @roblourens expects to resolve.

This was referenced Mar 11, 2019
Closed
Closed
@joaomoreno
Copy link
Member

joaomoreno commented Mar 11, 2019 •
edited

@bpasero This is a regression. I made a command available to test this a couple releases ago: Developer: Open URL. When I use it to open a URL in 1.31 it works. It doesn't in 1.32.

Will bisect it.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug workbench-os-integration Native OS integration issues labels Mar 11, 2019
@joaomoreno joaomoreno changed the title Open vscode://file/<path> in vscode is broken on mac after upgraded to 1.32? Open vscode://file/<path> in vscode is broke Mar 11, 2019
@joaomoreno joaomoreno changed the title Open vscode://file/<path> in vscode is broke Open vscode://file/<path> in vscode is broken Mar 11, 2019
@joaomoreno
Copy link
Member

joaomoreno commented Mar 11, 2019 •
edited 

8c6e97456e260c4136dd24c1948d8fb9a0f04b43 is the first bad commit
commit 8c6e97456e260c4136dd24c1948d8fb9a0f04b43
Author: Martin Aeschlimann <martinae@microsoft.com>
Date:   Wed Feb 6 16:56:53 2019 +0100

    IWindowService.openWindow takes IURIToOpen
:040000 040000 bbbaff84accf810921f7d3725d1d3e40721142d3 f8782f14f2f3b5899fbc9df9f10f2efa1088486e M      src

cc @aeschli 8c6e974

aeschli added a commit that referenced this issue Mar 11, 2019
@aeschli
Open vscode://file/<path> in vscode is broken. Fixes #69998
21bba56
joaomoreno added a commit that referenced this issue Mar 11, 2019
@joaomoreno
Merge pull request #70213 from Microsoft/aeschli/fix-69998
bd84189 
Open vscode://file/<path> in vscode is broken. Fixes #69998
@ornic ornic mentioned this issue Mar 11, 2019
Closed
@joaomoreno joaomoreno removed their assignment Mar 11, 2019
@yume-chan yume-chan mentioned this issue Mar 12, 2019
Closed
@octref octref added the verified Verification succeeded label Mar 13, 2019
This was referenced Apr 2, 2019
Closed
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded workbench-os-integration Native OS integration issues
Projects
None yet
Milestone
February 2019 Recovery 2
Development

No branches or pull requests
7 participants
@joaomoreno @bpasero @jrieken @ije @octref @aeschli @jameschenjav