Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm "Undo last commit" if its a merge commit #71525

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@jmbockhorst
Copy link
Contributor

jmbockhorst commented Apr 1, 2019

Added a confirmation notification when trying to undo the last commit if it was a merge commit. Closes #69937.

confirmMergeUndo

@joaomoreno joaomoreno added this to the Backlog milestone Apr 1, 2019
@joaomoreno joaomoreno added the git label Apr 1, 2019
@wesinator

This comment has been minimized.

Copy link
Contributor

wesinator commented Jun 25, 2019

Why not prompt for confirmation in all cases - #76107 ?

@joaomoreno joaomoreno modified the milestones: Backlog, October 2019 Oct 17, 2019
@joaomoreno joaomoreno merged commit fd8383a into microsoft:master Oct 17, 2019
5 checks passed
5 checks passed
VS Code Build #20190401.1 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Oct 17, 2019

Thanks! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.