Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quick pick message size #73359

Merged
merged 3 commits into from
May 7, 2019
Merged

Fix quick pick message size #73359

merged 3 commits into from
May 7, 2019

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented May 6, 2019

Fixes #73345

@alexr00 alexr00 added this to the April 2019 milestone May 6, 2019
@alexr00 alexr00 requested a review from chrmarti May 6, 2019 15:58
@alexr00 alexr00 self-assigned this May 6, 2019
@alexr00
Copy link
Member Author

alexr00 commented May 6, 2019

Stable on the left, running from source on the right:
image

@alexr00
Copy link
Member Author

alexr00 commented May 6, 2019

Warning message:
image

@chrmarti
Copy link
Contributor

chrmarti commented May 7, 2019

The second horizontal red line should align with the OK button vertically (like the first horizontal red line). The warning message looks like it's not well centered vertically, is it different from the input box's text?

@alexr00
Copy link
Member Author

alexr00 commented May 7, 2019

Without red border:
image
With red border:
image

I drew a line and made sure they line up now :)

@alexr00 alexr00 merged commit 8ef8aa6 into master May 7, 2019
@alexr00 alexr00 deleted the alexr00/QuickPickMessageSize branch May 7, 2019 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick input has some extra height pixels
2 participants