Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode-xterm #73599

Merged
merged 12 commits into from
May 13, 2019
Merged

Update vscode-xterm #73599

merged 12 commits into from
May 13, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented May 10, 2019

Fixes #18544
Fixes #67468
Fixes #69249
Fixes #70749
Fixes #73360
Fixes #73459

Diff: microsoft/xterm.js@199da84...5c9d66f

Includes PRs:


TODO

  • Test on all platforms
    • macOS
    • Linux
    • Windows
  • Verify private event usage
    • _onScroll
    • _onKey
  • Add typings for events used in core
  • Verify usages inside _core are still correct
  • Annotate fixed items on PR

@Tyriar Tyriar added this to the May 2019 milestone May 10, 2019
@Tyriar Tyriar self-assigned this May 10, 2019
@Tyriar Tyriar merged commit 744fefa into master May 13, 2019
@Tyriar Tyriar deleted the tyriar/xterm-update branch May 13, 2019 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.