Makes sense to not have them in there. I would think there should be a context key set whenever the editor is not used as a real text editor and then we can change those registrations.

There should be a context keys for this. Every editor should have this property is simple widget something.
I can look into adding this context keys for the two actions.

There is a context key isInEmbeddedEditor https://github.com/microsoft/vscode/blob/master/src/vs/editor/common/editorContextKeys.ts#L31 but it's only used in Playground/Walkthrough. We should probably make better use of it.

I can look into this this mielstone, thus assignign to October and removing other asignees.

@rebornix please review the fix. I checked out how it beahves and it seems good.
Adding label bug so we verify this

Thanks, I’ll take a look.

@isidorn not sure if I understand it incorrectly, restricting the command to ContextKeyExpr.and(EditorContextKeys.writable, EditorContextKeys.editorTextFocus) doesn't filter it out from Comment Editor, right?

I believe it does. Because the editorTextFocus is set only when the editor is not a simple widget. Check it out here https://github.com/Microsoft/vscode/blob/f554449e3baa6db81c04ed2c321c60ec3a8e9b9f/src/vs/editor/browser/widget/codeEditorWidget.ts#L1640

And I hope the comment editor is a simple editor widget like the repl input is. I set this here https://github.com/Microsoft/vscode/blob/f554449e3baa6db81c04ed2c321c60ec3a8e9b9f/src/vs/workbench/contrib/codeEditor/browser/simpleEditorOptions.ts#L43

I did use the simple editor by following repl input but turned out that language features won't be enabled when doing so. But we may still want to do so otherwise it's polluting the extension API.

Yeah. If you can make it to be a simple editor widget that would be great.
Not sure if possible since you want all the language features though.

@isidorn thanks, I changed it to simple editor and considering we only need suggestion / snippet, it should be fine.

@rebornix great, thanks for doing that.