Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes status zoom button a IStatusbarEntry #74454 #75618

Merged
merged 1 commit into from Jun 21, 2019

Conversation

Projects
None yet
4 participants
@burknator
Copy link
Contributor

commented Jun 17, 2019

Resolves #74454

ZoomStatusbarItem can now be instantiated, which is done in
InlineImageView, which it uses to update the status bar.
The needed services are passed down via constructors,
starting in BaseBinaryResourceEditor.
Also, the ID of status bar items is now assigned as the
id-attribute of the item's container.

@msftclas

This comment has been minimized.

Copy link

commented Jun 17, 2019

CLA assistant check
All CLA requirements met.

@bpasero bpasero added this to the June 2019 milestone Jun 17, 2019

@bpasero bpasero requested review from bpasero and removed request for bpasero Jun 17, 2019

@bpasero

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

@burknator can you also remove the a.zoom-statusbar-item entry from resourceviewer.css

Makes status zoom button a IStatusbarEntry #74454
ZoomStatusbarItem can now be instantiated, which is done in
InlineImageView, which it uses to update the status bar.
The needed services are passed down via constructors,
starting in BaseBinaryResourceEditor.
Removes padding from CSS which was necessary because of previous
implementation.

@burknator burknator force-pushed the burknator:fixes/image-zoom-button branch from 9691997 to a4ac3aa Jun 17, 2019

@burknator

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

Of course! Took mental note of that, should've written it down instead...

@mjbvz mjbvz merged commit 2155c06 into microsoft:master Jun 21, 2019

5 checks passed

VS Code Build #20190617.35 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

Thanks! Scheduled for VS Code 1.36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.