Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace getDefaultShell and mergeDefaultShellPathAndArgs with getDefaultShellAndArgs #75799

Merged
merged 5 commits into from Jun 19, 2019

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jun 19, 2019

All consumers of these calls wanted both shell and args, so instead of having both, move to a more simpler approach that just requested the defaults. There are 3 ways that shell and args can now be fetched:

  • Local: electron-browser/ITerminalInstanceService calls directly (we don't want to move this to ext host as that would delay the first terminal creation until after the ext host is up)
  • Web: browser/ITerminalInstanceService proxies the call to the ext host
  • Remote: ExtHostTerminalService calls directly when the process is being created on the ext host

This also renames getDefaultShell in node/terminal.ts to getSystemShell in order to differentiate the system shell (detected system default) with the default shell (default for vscode, based on settings + system).

Fixes #75795

@Tyriar Tyriar added this to the June 2019 milestone Jun 19, 2019
@Tyriar Tyriar requested a review from alexr00 June 19, 2019 22:57
@Tyriar Tyriar self-assigned this Jun 19, 2019
@Tyriar Tyriar merged commit 8bb86a8 into master Jun 19, 2019
@Tyriar Tyriar deleted the tyriar/exthost_shell_calls branch June 19, 2019 23:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getDefaultShell and mergeDefaultShellPathAndArgs need to be called from browser for tasks
1 participant