Replace getDefaultShell and mergeDefaultShellPathAndArgs with getDefaultShellAndArgs #75799
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All consumers of these calls wanted both shell and args, so instead of having both, move to a more simpler approach that just requested the defaults. There are 3 ways that shell and args can now be fetched:
electron-browser/ITerminalInstanceService
calls directly (we don't want to move this to ext host as that would delay the first terminal creation until after the ext host is up)browser/ITerminalInstanceService
proxies the call to the ext hostExtHostTerminalService
calls directly when the process is being created on the ext hostThis also renames
getDefaultShell
in node/terminal.ts togetSystemShell
in order to differentiate the system shell (detected system default) with the default shell (default for vscode, based on settings + system).Fixes #75795