Create browser version of telemetry service #77437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMacfarlane
force-pushed
the
rmacfarlane/browsertelemetry
branch
from
d3127b1
to
5c01c81
Compare
|
@RMacfarlane yeah I am not very happy to require clients to add the script for application insights into the HTML page. A better approach would be to require this in the same way as we for example ship I created #78475 as follow up for August. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new version of the telemetry service in
browserthat uses the app insights js library to send events.Some of the data for the common properties still isn’t coming through since it’s undefined in the browser version of the product or environment service,
machineIdis an important one of those. So still need to revisit that.