Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

files.exclude applies to findFiles() result when null provided as exclude argument #77813

Closed
deitry opened this issue Jul 23, 2019 · 6 comments
Closed

files.exclude applies to findFiles() result when null provided as exclude argument #77813

deitry opened this issue Jul 23, 2019 · 6 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
July 2019

Comments

@deitry
Copy link

deitry commented Jul 23, 2019

There is an extension which use findFiles() API:
https://github.com/matepek/vscode-catch2-test-adapter/blob/474e6c3d06f7bc3706ac8ec21cdcfa8ad1b4c35b/src/FSWatcher.ts#L101

I notice that extension could not find executables inside build/ when this folder is listed in files.exclude configuration: matepek/vscode-catch2-test-adapter#113

As documentation stated, no excludes should apply when null is provided, so developer of extension and me consider this a bug.

Tested on VSCode Stable 1.36.1
@jrieken jrieken assigned roblourens and unassigned jrieken Jul 23, 2019
@roblourens
Copy link
Member

This is by design, and has always been this way, but I will update the comment on the vscode.d.ts to reflect this.

@jrieken
Copy link
Member

jrieken commented Jul 24, 2019

When undefined only default excludes will apply. When null, no search excludes will apply, but files.exclude will still apply.

@roblourens I am super confused by that and don't believe that this is by design. Wasn't #33528 about that? Re-opening for a better clarification of the issue

@jrieken jrieken reopened this Jul 24, 2019
@deitry deitry mentioned this issue Jul 24, 2019
Closed
@roblourens
Copy link
Member

What I said makes no sense, I was misinterpreting a comment I made in an earlier issue. There is some bug here.

@roblourens
Copy link
Member

This is from 10c0126#diff-667e490a03391a012e309e8a660ce628R539 :( I will add tests

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Jul 24, 2019
@roblourens roblourens added this to the July 2019 milestone Jul 24, 2019
@jrieken
Copy link
Member

jrieken commented Jul 25, 2019

Thanks!

@deitry
Copy link
Author

deitry commented Jul 25, 2019

Thank you!

@octref octref added the verified Verification succeeded label Aug 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
July 2019
Development

No branches or pull requests
4 participants
@roblourens @jrieken @octref @deitry