Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Telemetry: avoid script import and use module instead #78475

Closed
bpasero opened this issue Aug 5, 2019 · 1 comment
Closed

Web Telemetry: avoid script import and use module instead #78475

bpasero opened this issue Aug 5, 2019 · 1 comment
Assignees
@RMacfarlane
Labels
debt Code quality issues telemetry Telemetry system issues web Issues related to running VSCode in the web
Milestone
August 2019

Comments

@bpasero
Copy link
Member

bpasero commented Aug 5, 2019

From #77437

Instead of having a script tag in the main HTML page to require the telemetry dependency, we should convert it to a NPM (UMD) module and require it as such. You can follow the traces of semver-umd as an example.
@bpasero bpasero added debt Code quality issues telemetry Telemetry system issues web Issues related to running VSCode in the web labels Aug 5, 2019
@bpasero bpasero added this to the August 2019 milestone Aug 5, 2019
@bpasero bpasero mentioned this issue Aug 5, 2019
Merged
@bpasero
Copy link
Member Author

bpasero commented Aug 8, 2019

@RMacfarlane thanks!

RMacfarlane pushed a commit that referenced this issue Aug 12, 2019
Use application insights module, #78475, fixes #78840
8ffdc18
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 21, 2019
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Use application insights module instead of script tag, fixes microsof…
ab09295 
…t#78475
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Revert "Use application insights module instead of script tag, fixes m…
e7f14b7 
…icrosoft#78475"

This reverts commit 803e140.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
debt Code quality issues telemetry Telemetry system issues web Issues related to running VSCode in the web
Projects
None yet
Milestone
August 2019
Development

No branches or pull requests
2 participants
@bpasero @RMacfarlane