Fix markdown issues #7884
Merged
Fix markdown issues #7884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @kieferrm to be a potential reviewer |
| <array> | ||
| <dict> | ||
| <key>include</key> | ||
| <string>text.html.php</string> |
There was a problem hiding this comment.
It's the same as the scopeName inside php syntax file, but currently the inline highlighting doesn't work. Will look into it later on.
rebornix
force-pushed
the
FixMarkdownIssues
branch
from
78a4e09
to
db7a7f8
Compare
|
@rebornix if this is for June, please check it in by today. |
|
@bpasero Kai told me he will merge this last time we synced so it's up to him which release he wants this change in, I don't get the privilege to check in yet. |
|
Ok maybe you ask him in person, I am not sure he checks GH notifications. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The markdown plist language include section is generated by scripts I wrote, no idea why PHP was missing in the beginning. But now I bring it back. Fixes #3746 .
The second commit is adding brackets auto-closing in markdown. Fixes #6113 .