Remove Terminal.onDidWriteData

[Tyriar]

Replaced by vscode.window.onDidWriteTerminalData

Fixes #78574

[Tyriar]

@weinand fyi debug-server-ready was on a deprecated API that just got removed, I didn't test this so please review.

[weinand]

@Tyriar the serverReadyAction feature no longer works in the integrated terminal since the package.json is missing a "enableProposedApi": true.

I addition I will have to rewrite the code because the old implementation tried to be very careful to register onDidWriteData only for those terminals that actually use the feature. With the new API this is no longer possible as onDidWriteTerminalData gets all data for all terminals and the filtering has to be done after the fact.

I'm not sure that the new API is an improvement. It is definitely not performance-wise.

/cc @jrieken

[jrieken]

new API is an improvement. It is definitely not performance-wise.

That's on purpose. For once to align with the global event rules and then the VSLS use-case is to listen on all terminal anyways, hence no performance difference. Tho, because we are aware that (global and private events are equally dangerous) we have no plans to ever move that API out of proposed.

[Tyriar]

@weinand no longer works? That was never stable so how did it ever work? @jrieken and I have spoken at length about performance and security and that's why the plan is it leave it as proposed.