Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Active inline breakpoint isn't highlighted #81718

Closed
jrieken opened this issue Oct 1, 2019 · 3 comments
Closed

Active inline breakpoint isn't highlighted #81718

jrieken opened this issue Oct 1, 2019 · 3 comments
Assignees
@isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2019

Comments

@jrieken
Copy link
Member

jrieken commented Oct 1, 2019 •
edited

re #81175

Oct-01-2019 11-21-49
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Oct 1, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 1, 2019

Good catch. We currently do not support this.
And yes it makes perfect sense. So assigning first to September though I might move it out to next week.

@isidorn isidorn modified the milestones: October 2019, September 2019 Oct 1, 2019
@isidorn isidorn mentioned this issue Oct 3, 2019
Closed
@isidorn
Copy link
Contributor

isidorn commented Oct 25, 2019

We now support this as shown by this gif:
Verifier: make sure that when the inline breakpoint is at the same location as the top stack frame indicator that you get one decoration and not two. The one decroation should be the yellow arrow with a red dot inside (as shown in the .gif)

inlineBreakpoints

@isidorn isidorn added the verification-needed Verification of issue is requested label Oct 25, 2019
@jrieken jrieken added the verified Verification succeeded label Oct 29, 2019
connor4312 added a commit that referenced this issue Nov 1, 2019
@connor4312
debug - fix active line for column-free breakpoints not be decorated …
e7716c5 
…correctly

In #81718 we adjusted breakpoint display logic to show an 'empty' arrow on the
line, and the arrow with a dot at the column where the debugger is running.
However, not all debuggers support column breakpoints. Bowden noticed, while
working on his Python demo for ignite, that breakpoints in Python code no
longer displayed correctly.

This PR tweaks the logic so that if we see a breakpoint that doesn't have
an associated column, we show the arrow with a dot on the line, rather than
assuming that there'll be an inline indicator arrow.
@connor4312 connor4312 mentioned this issue Nov 1, 2019
Merged
@connor4312
Copy link
Member

I found an issue with this change and opened a PR for it: #83851

connor4312 added a commit that referenced this issue Nov 1, 2019
@connor4312
debug - fix active line for column-free breakpoints not be decorated …
372ed29 
…correctly

In #81718 we adjusted breakpoint display logic to show an 'empty' arrow on the
line, and the arrow with a dot at the column where the debugger is running.
However, not all debuggers support column breakpoints. Bowden noticed, while
working on his Python demo for ignite, that breakpoints in Python code no
longer displayed correctly.

This PR tweaks the logic so that if we see a breakpoint that doesn't have
an associated column, we show the arrow with a dot on the line, rather than
assuming that there'll be an inline indicator arrow.
connor4312 added a commit that referenced this issue Nov 1, 2019
@connor4312
debug - fix active line for column-free breakpoints not be decorated …
a14de79 
…correctly

In #81718 we adjusted breakpoint display logic to show an 'empty' arrow on the
line, and the arrow with a dot at the column where the debugger is running.
However, not all debuggers support column breakpoints. Bowden noticed, while
working on his Python demo for ignite, that breakpoints in Python code no
longer displayed correctly.

This PR tweaks the logic so that if we see a breakpoint that doesn't have
an associated column, we show the arrow with a dot on the line, rather than
assuming that there'll be an inline indicator arrow.
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@jrieken @isidorn @connor4312