debug - fix active line for column-free breakpoints not be decorated correctly #83851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correctly In #81718 we adjusted breakpoint display logic to show an 'empty' arrow on the line, and the arrow with a dot at the column where the debugger is running. However, not all debuggers support column breakpoints. Bowden noticed, while working on his Python demo for ignite, that breakpoints in Python code no longer displayed correctly. This PR tweaks the logic so that if we see a breakpoint that doesn't have an associated column, we show the arrow with a dot on the line, rather than assuming that there'll be an inline indicator arrow.
connor4312
added
bug
sbatten
approved these changes
Nov 1, 2019
RMacfarlane
approved these changes
Nov 1, 2019
|
@connor4312 Thanks for fixing this. Also fyi #83757 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #81718 we adjusted breakpoint display logic to show an 'empty' arrow on the
line, and the arrow with a dot at the column where the debugger is running.
However, not all debuggers support column breakpoints. @bowdenk7 noticed, while
working on his Python demo for ignite, that breakpoints in Python code no
longer displayed correctly.
This PR tweaks the logic so that if we see a breakpoint that doesn't have
an associated column, we show the arrow with a dot on the line, rather than
assuming that there'll be an inline indicator arrow.
Python before this fix:
Python with this fix:
It doesn't appear to affect Node.js debugging (where columns are supported), the same before and after: