Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blank screen with a reinstalled 1.39.1 #82467

Closed
dotnetCarpenter opened this issue Oct 13, 2019 · 11 comments
Closed

Blank screen with a reinstalled 1.39.1 #82467

dotnetCarpenter opened this issue Oct 13, 2019 · 11 comments
Assignees
@sbatten
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues verified Verification succeeded
Milestone
September 2019 Re...

Comments

@dotnetCarpenter
Copy link

dotnetCarpenter commented Oct 13, 2019 •
edited

Error restoring editor grid widget: TypeError: Cannot read property 'indexOf' of undefined

  • VSCode Version: 1.39.1 88f15d1
  • OS Version: Version 1903 (18362.418)

Steps to Reproduce:

  1. Not sure, but I use vscode from both WSL and PowserShell 6.
  2. Before it happened I was running vscode from an elevated PowerShell 6.
  3. After that - almost blank. I can see the background colors. But no icons and nothing else.
  4. The same result when open in WSL as in PowerShell.
  5. Possible to get working via code -n . to open a new window but not consistently.

Does this issue occur when all extensions are disabled?: Yes

renderer1.log 

[2019-10-13 19:27:29.196] [renderer1] [error] Error restoring editor grid widget: TypeError: Cannot read property 'indexOf' of undefined (with state: {"serializedGrid":{"root":{"type":"branch","data":[{"type":"leaf","data":{"id":6,"editors":[{"id":"workbench.editors.files.fileEditorInput","value":"{\"resource\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/package.json\",\"resourceJSON\":{\"$mid\":1,\"fsPath\":\"\\\\home\\\\dotnet\\\\projects\\\\napp\\\\webviewer-core\\\\package.json\",\"_sep\":1,\"external\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/package.json\",\"path\":\"/home/dotnet/projects/napp/webviewer-core/package.json\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},\"encoding\":\"utf8\"}"},{"id":"workbench.editors.files.fileEditorInput","value":"{\"resource\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/CHANGELOG.md\",\"resourceJSON\":{\"$mid\":1,\"fsPath\":\"\\\\home\\\\dotnet\\\\projects\\\\napp\\\\webviewer-core\\\\CHANGELOG.md\",\"_sep\":1,\"external\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/CHANGELOG.md\",\"path\":\"/home/dotnet/projects/napp/webviewer-core/CHANGELOG.md\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},\"encoding\":\"utf8\"}"},{"id":"workbench.editors.files.fileEditorInput","value":"{\"resource\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/README.md\",\"resourceJSON\":{\"$mid\":1,\"fsPath\":\"\\\\home\\\\dotnet\\\\projects\\\\napp\\\\webviewer-core\\\\README.md\",\"_sep\":1,\"external\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/README.md\",\"path\":\"/home/dotnet/projects/napp/webviewer-core/README.md\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},\"encoding\":\"utf8\"}"},{"id":"workbench.editors.files.fileEditorInput","value":"{\"resource\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/less/viewer/annotation.less\",\"resourceJSON\":{\"$mid\":1,\"fsPath\":\"\\\\home\\\\dotnet\\\\projects\\\\napp\\\\webviewer-core\\\\less\\\\viewer\\\\annotation.less\",\"_sep\":1,\"external\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/less/viewer/annotation.less\",\"path\":\"/home/dotnet/projects/napp/webviewer-core/less/viewer/annotation.less\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},\"encoding\":\"utf8\"}"}],"mru":[3,2,1,0]},"size":626},{"type":"leaf","data":{"id":7,"editors":[{"id":"workbench.editors.webviewInput","value":"{\"id\":\"b4b135ab-7982-42cd-9deb-3d6c8e12ce2d\",\"viewType\":\"mainThreadWebview-markdown.preview\",\"title\":\"Preview README.md\",\"options\":{\"enableFindWidget\":true,\"enableScripts\":true,\"localResourceRoots\":[{\"$mid\":1,\"external\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features\",\"path\":\"/home/dotnet/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},{\"$mid\":1,\"external\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core\",\"path\":\"/home/dotnet/projects/napp/webviewer-core\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"}],\"allowScripts\":true},\"extensionLocation\":{\"$mid\":1,\"path\":\"/home/dotnet/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},\"extensionId\":\"vscode.markdown-language-features\",\"iconPath\":{\"light\":{\"$mid\":1,\"path\":\"/home/dotnet/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features/media/preview-light.svg\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},\"dark\":{\"$mid\":1,\"path\":\"/home/dotnet/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features/media/preview-dark.svg\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"}},\"group\":7}"}],"mru":[0]},"size":626}],"size":848},"orientation":1,"width":1252,"height":848},"activeGroup":6,"mostRecentActiveGroups":[6,7]}): Error: Error restoring editor grid widget: TypeError: Cannot read property 'indexOf' of undefined (with state: {"serializedGrid":{"root":{"type":"branch","data":[{"type":"leaf","data":{"id":6,"editors":[{"id":"workbench.editors.files.fileEditorInput","value":"{\"resource\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/package.json\",\"resourceJSON\":{\"$mid\":1,\"fsPath\":\"\\\\home\\\\dotnet\\\\projects\\\\napp\\\\webviewer-core\\\\package.json\",\"_sep\":1,\"external\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/package.json\",\"path\":\"/home/dotnet/projects/napp/webviewer-core/package.json\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},\"encoding\":\"utf8\"}"},{"id":"workbench.editors.files.fileEditorInput","value":"{\"resource\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/CHANGELOG.md\",\"resourceJSON\":{\"$mid\":1,\"fsPath\":\"\\\\home\\\\dotnet\\\\projects\\\\napp\\\\webviewer-core\\\\CHANGELOG.md\",\"_sep\":1,\"external\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/CHANGELOG.md\",\"path\":\"/home/dotnet/projects/napp/webviewer-core/CHANGELOG.md\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},\"encoding\":\"utf8\"}"},{"id":"workbench.editors.files.fileEditorInput","value":"{\"resource\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/README.md\",\"resourceJSON\":{\"$mid\":1,\"fsPath\":\"\\\\home\\\\dotnet\\\\projects\\\\napp\\\\webviewer-core\\\\README.md\",\"_sep\":1,\"external\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/README.md\",\"path\":\"/home/dotnet/projects/napp/webviewer-core/README.md\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},\"encoding\":\"utf8\"}"},{"id":"workbench.editors.files.fileEditorInput","value":"{\"resource\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/less/viewer/annotation.less\",\"resourceJSON\":{\"$mid\":1,\"fsPath\":\"\\\\home\\\\dotnet\\\\projects\\\\napp\\\\webviewer-core\\\\less\\\\viewer\\\\annotation.less\",\"_sep\":1,\"external\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core/less/viewer/annotation.less\",\"path\":\"/home/dotnet/projects/napp/webviewer-core/less/viewer/annotation.less\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},\"encoding\":\"utf8\"}"}],"mru":[3,2,1,0]},"size":626},{"type":"leaf","data":{"id":7,"editors":[{"id":"workbench.editors.webviewInput","value":"{\"id\":\"b4b135ab-7982-42cd-9deb-3d6c8e12ce2d\",\"viewType\":\"mainThreadWebview-markdown.preview\",\"title\":\"Preview README.md\",\"options\":{\"enableFindWidget\":true,\"enableScripts\":true,\"localResourceRoots\":[{\"$mid\":1,\"external\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features\",\"path\":\"/home/dotnet/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},{\"$mid\":1,\"external\":\"vscode-remote://wsl%2Bubuntu/home/dotnet/projects/napp/webviewer-core\",\"path\":\"/home/dotnet/projects/napp/webviewer-core\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"}],\"allowScripts\":true},\"extensionLocation\":{\"$mid\":1,\"path\":\"/home/dotnet/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},\"extensionId\":\"vscode.markdown-language-features\",\"iconPath\":{\"light\":{\"$mid\":1,\"path\":\"/home/dotnet/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features/media/preview-light.svg\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"},\"dark\":{\"$mid\":1,\"path\":\"/home/dotnet/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features/media/preview-dark.svg\",\"scheme\":\"vscode-remote\",\"authority\":\"wsl+Ubuntu\"}},\"group\":7}"}],"mru":[0]},"size":626}],"size":848},"orientation":1,"width":1252,"height":848},"activeGroup":6,"mostRecentActiveGroups":[6,7]})
    at e.doCreateGridControlWithPreviousState (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5494:182)
    at e.doCreateGridControl (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5493:549)
    at e.createContentArea (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5493:36)
    at e.create (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2671:576)
    at forEach (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5543:408)
    at Array.forEach ()
    at t.Workbench.renderWorkbench (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5543:315)
    at e.invokeFunction (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5540:356)
    at h.invokeFunction (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1504:876)
    at t.Workbench.startup (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5540:94)
    at Q.open (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6084:899)
[2019-10-13 19:27:29.290] [renderer1] [error] Cannot read property 'element' of undefined: TypeError: Cannot read property 'element' of undefined
    at F.doRedrawEditorActive (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5449:684)
    at F.redrawEditorActiveAndDirty (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5448:583)
    at forEachTab (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5440:100)
    at group.editors.forEach (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5447:430)
    at Array.forEach ()
    at F.forEachTab (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5447:372)
    at F.setActive (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5440:70)
    at e.setActive (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5471:335)
    at e.doSetGroupActive (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5489:846)
    at e.doCreateGridControl (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5493:696)
    at e.createContentArea (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5493:36)
    at e.create (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2671:576)
    at forEach (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5543:408)
    at Array.forEach ()
    at t.Workbench.renderWorkbench (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5543:315)
    at e.invokeFunction (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5540:356)
    at h.invokeFunction (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1504:876)
    at t.Workbench.startup (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5540:94)
    at Q.open (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6084:899)
[2019-10-13 19:27:37.057] [renderer1] [error] Cannot read property 'styles' of undefined: TypeError: Cannot read property 'styles' of undefined
    at e.updateStyles (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5492:883)
    at e.onThemeChange (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2656:134)
    at e.onThemeChange (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2671:434)
    at _register.themeService.onThemeChange.e (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2656:80)
    at c.fire (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:116:519)
    at P.applyTheme (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:4682:610)
    at s.ensureLoaded.then.i (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:4681:209)
[2019-10-13 19:27:37.068] [renderer1] [error] Cannot read property 'count' of undefined: TypeError: Cannot read property 'count' of undefined
    at e.get isEmpty [as isEmpty] (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5470:968)
    at e.updateStyles (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5478:526)
    at e.onThemeChange (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2656:134)
    at _register.themeService.onThemeChange.e (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2656:80)
    at c.fire (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:116:519)
    at P.applyTheme (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:4682:610)
    at s.ensureLoaded.then.i (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:4681:209)
[2019-10-13 19:37:20.341] [renderer1] [error] Cannot read property 'state' of undefined: TypeError: Cannot read property 'state' of undefined
    at e.saveState (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5495:835)
    at _register.n.onWillSaveState (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2667:168)
    at c.fire (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:116:519)
    at e.close (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2462:311)
    at _register.e.onWillShutdown.e (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6085:464)
    at c.fire (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:116:519)
    at _register.e.onWillShutdown.e (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5541:374)
    at c.fire (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:116:519)
    at e.handleWillShutdown (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3784:1019)
    at EventEmitter.o.ipcRenderer.on (file:///C:/Users/dotnet/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:3784:508)
    at EventEmitter.emit (events.js:182:13)

vscode_blank
@bl4val
Copy link

bl4val commented Oct 13, 2019

Happens only in devcontainers for me.

@jrieken jrieken added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Oct 14, 2019
@jrieken
Copy link
Member

jrieken commented Oct 14, 2019

duplicate of the entered layout issue?

@isidorn
Copy link
Contributor

isidorn commented Oct 14, 2019 •
edited

Editor grid widget, assigning to @sbatten
fyi @joaomoreno
Adding candidate since sounds serious

@isidorn isidorn assigned sbatten and unassigned bpasero and isidorn Oct 14, 2019
@isidorn isidorn added the candidate Issue identified as probable candidate for fixing in the next release label Oct 14, 2019
@jrieken jrieken added this to the September 2019 Recovery 2 milestone Oct 14, 2019
@joaomoreno
Copy link
Member

@dotnetCarpenter Can you open DevTools, is there any error in there?

@joaomoreno
Copy link
Member

Oh I see you have a trace! 🙏

@joaomoreno
Copy link
Member

Seems unrelated to #82218. Let's wait for @sbatten

@bl4val
Copy link

bl4val commented Oct 14, 2019 •
edited

Same error for me:
log.ts:196 ERR Error restoring editor grid widget: TypeError: Cannot read property 'indexOf' of undefined (with state: {"serializedGrid":{"root":{"type":"branch","data":[{"type":"leaf","data":{"id":0,"editors":[{"id":"workbench.editors.files.fileEditorInput","value":"{\"resource\":\"vscode-remote://dev-container%2B633a5c6…/code/README.md\",\"resourceJSON\":{\"$mid\":1,\"fsPath\":\"\\\\code\\\\README.md\",\"_sep\":1,\"external\":\"vscode-remote://dev-container%2B633a5c6…/code/README.md\",\"path\":\"/code/README.md\",\"scheme\":\"vscode-remote\",\"authority\":\"dev-container+633a5c636f64655c6e6f6973652d6265\"},\"encoding\":\"utf8\"}"}],"mru":[0]},"size":764},{"type":"leaf","data":{"id":1,"editors":[{"id":"workbench.editors.webviewInput","value":"{\"id\":\"81bdadfb-4327-465a-baba-89aadeb558ce\",\"viewType\":\"mainThreadWebview-markdown.preview\",\"title\":\"Preview README.md\",\"options\":{\"enableFindWidget\":true,\"enableScripts\":true,\"localResourceRoots\":[{\"$mid\":1,\"external\":\"vscode-remote://dev-container%2B633a5c6…/root/.vsco…d17dca8…/extensions/markdown-language-features\",\"path\":\"/root/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features\",\"scheme\":\"vscode-remote\",\"authority\":\"dev-container+633a5c636f64655c6e6f6973652d6265\"},{\"$mid\":1,\"external\":\"vscode-remote://dev-container%2B633a5c6…/code\",\"path\":\"/code\",\"scheme\":\"vscode-remote\",\"authority\":\"dev-container+633a5c636f64655c6e6f6973652d6265\"}],\"allowScripts\":true},\"extensionLocation\":{\"$mid\":1,\"path\":\"/root/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features\",\"scheme\":\"vscode-remote\",\"authority\":\"dev-container+633a5c636f64655c6e6f6973652d6265\"},\"extensionId\":\"vscode.markdown-language-features\",\"iconPath\":{\"light\":{\"$mid\":1,\"path\":\"/root/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features/media/preview-light.svg\",\"scheme\":\"vscode-remote\",\"authority\":\"dev-container+633a5c636f64655c6e6f6973652d6265\"},\"dark\":{\"$mid\":1,\"path\":\"/root/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features/media/preview-dark.svg\",\"scheme\":\"vscode-remote\",\"authority\":\"dev-container+633a5c636f64655c6e6f6973652d6265\"}},\"group\":1}"}],"mru":[0]},"size":763}],"size":623},"orientation":1,"width":1527,"height":623},"activeGroup":0,"mostRecentActiveGroups":[0,1]}): Error: Error restoring editor grid widget: TypeError: Cannot read property 'indexOf' of undefined (with state: {"serializedGrid":{"root":{"type":"branch","data":[{"type":"leaf","data":{"id":0,"editors":[{"id":"workbench.editors.files.fileEditorInput","value":"{\"resource\":\"vscode-remote://dev-container%2B633a5c6…/code/README.md\",\"resourceJSON\":{\"$mid\":1,\"fsPath\":\"\\\\code\\\\README.md\",\"_sep\":1,\"external\":\"vscode-remote://dev-container%2B633a5c6…/code/README.md\",\"path\":\"/code/README.md\",\"scheme\":\"vscode-remote\",\"authority\":\"dev-container+633a5c636f64655c6e6f6973652d6265\"},\"encoding\":\"utf8\"}"}],"mru":[0]},"size":764},{"type":"leaf","data":{"id":1,"editors":[{"id":"workbench.editors.webviewInput","value":"{\"id\":\"81bdadfb-4327-465a-baba-89aadeb558ce\",\"viewType\":\"mainThreadWebview-markdown.preview\",\"title\":\"Preview README.md\",\"options\":{\"enableFindWidget\":true,\"enableScripts\":true,\"localResourceRoots\":[{\"$mid\":1,\"external\":\"vscode-remote://dev-container%2B633a5c6…/root/.vsco…d17dca8…/extensions/markdown-language-features\",\"path\":\"/root/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features\",\"scheme\":\"vscode-remote\",\"authority\":\"dev-container+633a5c636f64655c6e6f6973652d6265\"},{\"$mid\":1,\"external\":\"vscode-remote://dev-container%2B633a5c6…/code\",\"path\":\"/code\",\"scheme\":\"vscode-remote\",\"authority\":\"dev-container+633a5c636f64655c6e6f6973652d6265\"}],\"allowScripts\":true},\"extensionLocation\":{\"$mid\":1,\"path\":\"/root/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features\",\"scheme\":\"vscode-remote\",\"authority\":\"dev-container+633a5c636f64655c6e6f6973652d6265\"},\"extensionId\":\"vscode.markdown-language-features\",\"iconPath\":{\"light\":{\"$mid\":1,\"path\":\"/root/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features/media/preview-light.svg\",\"scheme\":\"vscode-remote\",\"authority\":\"dev-container+633a5c636f64655c6e6f6973652d6265\"},\"dark\":{\"$mid\":1,\"path\":\"/root/.vscode-server/bin/88f15d17dca836346e787762685a40bb5cce75a8/extensions/markdown-language-features/media/preview-dark.svg\",\"scheme\":\"vscode-remote\",\"authority\":\"dev-container+633a5c636f64655c6e6f6973652d6265\"}},\"group\":1}"}],"mru":[0]},"size":763}],"size":623},"orientation":1,"width":1527,"height":623},"activeGroup":0,"mostRecentActiveGroups":[0,1]}) at e.doCreateGridControlWithPreviousState (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5494:182) at e.doCreateGridControl (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5493:549) at e.createContentArea (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5493:36) at e.create (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2671:576) at forEach (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5543:408) at Array.forEach (<anonymous>) at t.Workbench.renderWorkbench (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5543:315) at e.invokeFunction (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5540:356) at h.invokeFunction (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1504:876) at t.Workbench.startup (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5540:94) at Q.open (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6084:899) log.ts:196 ERR Cannot read property 'element' of undefined: TypeError: Cannot read property 'element' of undefined at F.doRedrawEditorActive (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5449:428) at F.redrawEditorActiveAndDirty (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5448:583) at forEachTab (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5440:100) at group.editors.forEach (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5447:430) at Array.forEach (<anonymous>) at F.forEachTab (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5447:372) at F.setActive (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5440:70) at e.setActive (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5471:335) at e.doSetGroupActive (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5489:846) at e.doCreateGridControl (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5493:696) at e.createContentArea (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5493:36) at e.create (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:2671:576) at forEach (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5543:408) at Array.forEach (<anonymous>) at t.Workbench.renderWorkbench (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5543:315) at e.invokeFunction (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5540:356) at h.invokeFunction (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:1504:876) at t.Workbench.startup (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:5540:94) at Q.open (file:///C:/Users/otur-gaming/AppData/Local/Programs/Microsoft VS Code/resources/app/out/vs/workbench/workbench.desktop.main.js:6084:899)

@sbatten
Copy link
Member

sbatten commented Oct 14, 2019

I can repro with that trace. In both cases, this happens when a markdown preview is open and the stack I see when reproducing shows errors when restoring the webview. Still investigating further.

@sbatten
Copy link
Member

sbatten commented Oct 14, 2019 •
edited

The real error is coming from

vscode/src/vs/base/common/network.ts

Line 96 in 7e31d97

if (host.indexOf(':') !== -1) {
When the editors are being restored, the first time this function is called, the host is not yet defined and thus this is failing. Previously, we just passed this undefined value along but now we are operating on it. Simply adding host && host.indexOf... to conditional resolves the issue for me. @aeschli

@sbatten
Copy link
Member

sbatten commented Oct 14, 2019

I pushed the quick fix, but maybe we should look into delaying the editor restoration until the host information is available.

sbatten added a commit to sbatten/vscode that referenced this issue Oct 14, 2019
@sbatten
fix resource rewrite before host available
7aa3d90 
fixes microsoft#82467
@sbatten sbatten mentioned this issue Oct 14, 2019
Merged
sbatten added a commit that referenced this issue Oct 14, 2019
@sbatten
fix resource rewrite before host available (#82531)
68cd352 
fixes #82467
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Oct 15, 2019
@sbatten sbatten mentioned this issue Oct 15, 2019
Closed
@sbatten
Copy link
Member

sbatten commented Oct 15, 2019

To verify:

  1. Open a folder in WSL with a markdown file.
  2. Open a preview of the markdown file to the side.
  3. Reload the window.

Ensure that reload is successful and you don't have a blank window.

@Tyriar Tyriar added the verified Verification succeeded label Oct 15, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues verified Verification succeeded
Projects
None yet
Milestone
September 2019 Recovery 2
Development

No branches or pull requests
8 participants
@joaomoreno @dotnetCarpenter @bpasero @jrieken @isidorn @Tyriar @sbatten @bl4val