Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal link hover position is inconsistent with editor #83293

Closed
Tyriar opened this issue Oct 25, 2019 · 3 comments
Closed

Terminal link hover position is inconsistent with editor #83293

Tyriar opened this issue Oct 25, 2019 · 3 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue terminal Integrated terminal issues verified Verification succeeded
Milestone
October 2019

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 25, 2019

image

Expected:

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue terminal Integrated terminal issues labels Oct 25, 2019
@Tyriar Tyriar added this to the October 2019 milestone Oct 25, 2019
@Tyriar Tyriar self-assigned this Oct 25, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Oct 25, 2019

Fixed in #83175

Verifier please test only the position of the hover, not the content/style, that's covered in #78647

@Tyriar Tyriar closed this as completed Oct 25, 2019
@Tyriar Tyriar mentioned this issue Oct 25, 2019
Closed
@connor4312
Copy link
Member

connor4312 commented Oct 30, 2019 •
edited

Looks good overall.

There seems to be one edge case where if the top of the link is above the screen, we display the tooltip below its anchor position along the top...

Whereas vs code prefers to show it on the left side underneath the cursor

Marking this as "found" since it is an inconsistency, but feel free to mark verified if you think the implemented behavior is satisfactory. (and vscode has a different edge case here, #83695)

@connor4312 connor4312 added the verification-found Issue verification failed label Oct 30, 2019
@connor4312 connor4312 reopened this Oct 30, 2019
@Tyriar
Copy link
Member Author

Tyriar commented Oct 30, 2019

@connor4312 nice find 👍 I guess if the link starts above the viewport we should position is just below the (0,0) cell

@Tyriar Tyriar closed this as completed in 4057e3a Oct 30, 2019
@Tyriar Tyriar removed the verification-found Issue verification failed label Oct 30, 2019
@joaomoreno joaomoreno added the verified Verification succeeded label Oct 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@joaomoreno @Tyriar @connor4312