Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chevron to Safari and Firefox dropdowns #83793

Merged
merged 10 commits into from Nov 4, 2019

Conversation

miguelsolorio
Copy link
Contributor

@miguelsolorio miguelsolorio commented Oct 31, 2019

Related #83556
Fixes #83756

This adds the chevron to all of our dropdowns in Safari/Firefox:

image

@miguelsolorio miguelsolorio added web Issues related to running VSCode in the web firefox Issues running VSCode in Web on Firefox safari Issues running VSCode in Web on Safari labels Oct 31, 2019
@bpasero bpasero added this to the November 2019 milestone Nov 1, 2019
@bpasero bpasero removed their assignment Nov 1, 2019
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to November, as I think this is not too critical for now.

image

Looks very cool! Shouldn't we do this simply for Chrome/Electron as well then?

My only other comment would be that I would rather not have workbench-contribution specific CSS rules (like debug) in the core. Rather move them to debug or their respective area.

@miguelsolorio
Copy link
Contributor Author

@bpasero moved the styles out to their respective areas (Debug and Panel)

@bpasero
Copy link
Member

bpasero commented Nov 1, 2019

@misolori any objections using this on Chrome as well?

@miguelsolorio
Copy link
Contributor Author

miguelsolorio commented Nov 1, 2019

@bpasero sorry I missed that part about your comment, I don't see any objections and it makes sense to make it consistent across all of the platforms. I'll update this PR to reflect this.

@bpasero
Copy link
Member

bpasero commented Nov 1, 2019

Cool.

@bpasero
Copy link
Member

bpasero commented Nov 1, 2019

@misolori I see a couple of issues:

  • you cannot click the arrow to open the dropdown anymore

  • the arrow overflows with the content
    image

  • there is some cheese in the panel (if used in Chrome)

image

@bpasero
Copy link
Member

bpasero commented Nov 1, 2019

@misolori I pushed 863defb into your branch to make it a general thing, feel free to revert if you think that does not work

@miguelsolorio
Copy link
Contributor Author

I've updated the styles so it cleans it up in all browsers/platforms. I also had to set the appearance to none in order to remove the browser dropdown arrows.

FireFox

image

Chrome

image

Safari

image

OSS

image

@miguelsolorio
Copy link
Contributor Author

you cannot click the arrow to open the dropdown anymore

I need to look into this more, it seems like in the debug dropdown the selection input doesn't extend out to the icon.

@bpasero
Copy link
Member

bpasero commented Nov 2, 2019

Ok I can review once you figured that out if possible.

@miguelsolorio
Copy link
Contributor Author

@bpasero dropdown chevrons should now be clickable

Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some feedback. Also, I did only test macOS, can you check Windows and Linux too?

src/vs/workbench/browser/media/style.css Outdated Show resolved Hide resolved
src/vs/workbench/browser/parts/panel/media/panelpart.css Outdated Show resolved Hide resolved
@bpasero bpasero removed their assignment Nov 4, 2019
@miguelsolorio
Copy link
Contributor Author

✅ Windows (OSS, Chrome, Firefox)
✅ Linux (OSS, Chrome, Firefox)

@miguelsolorio miguelsolorio merged commit 6d9a949 into master Nov 4, 2019
@miguelsolorio miguelsolorio deleted the misolori/web-dropdowns branch November 4, 2019 18:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
firefox Issues running VSCode in Web on Firefox safari Issues running VSCode in Web on Safari web Issues related to running VSCode in the web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draw custom drop-down picker (Desktop, Web)
2 participants