New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chevron to Safari and Firefox dropdowns #83793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving to November, as I think this is not too critical for now.
Looks very cool! Shouldn't we do this simply for Chrome/Electron as well then?
My only other comment would be that I would rather not have workbench-contribution specific CSS rules (like debug) in the core. Rather move them to debug or their respective area.
@bpasero moved the styles out to their respective areas (Debug and Panel) |
@misolori any objections using this on Chrome as well? |
@bpasero sorry I missed that part about your comment, I don't see any objections and it makes sense to make it consistent across all of the platforms. I'll update this PR to reflect this. |
Cool. |
@misolori I pushed 863defb into your branch to make it a general thing, feel free to revert if you think that does not work |
I need to look into this more, it seems like in the debug dropdown the |
Ok I can review once you figured that out if possible. |
@bpasero dropdown chevrons should now be clickable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some feedback. Also, I did only test macOS, can you check Windows and Linux too?
✅ Windows (OSS, Chrome, Firefox) |
Related #83556
Fixes #83756
This adds the chevron to all of our dropdowns in Safari/Firefox: