Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug - fix active line for column-free breakpoints not be decorated correctly #83863

Merged
merged 1 commit into from
Nov 1, 2019

Commits on Nov 1, 2019

  1. debug - fix active line for column-free breakpoints not be decorated …

    …correctly
    
    In #81718 we adjusted breakpoint display logic to show an 'empty' arrow on the
    line, and the arrow with a dot at the column where the debugger is running.
    However, not all debuggers support column breakpoints. Bowden noticed, while
    working on his Python demo for ignite, that breakpoints in Python code no
    longer displayed correctly.
    
    This PR tweaks the logic so that if we see a breakpoint that doesn't have
    an associated column, we show the arrow with a dot on the line, rather than
    assuming that there'll be an inline indicator arrow.
    connor4312 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    e7716c5 View commit details
    Browse the repository at this point in the history