Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Show Control Hover (better naming) #83937

Merged
merged 2 commits into from Nov 4, 2019
Merged

Rename Show Control Hover (better naming) #83937

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e1a5c6
fixes #83912
sbatten Nov 4, 2019
abbf9c2
remove any mention of mod+hover
sbatten Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/vs/editor/contrib/hover/hover.ts
View file
Open in desktop
Expand Up @@ -259,19 +259,19 @@ class ShowHoverAction extends EditorAction {
}
}

class ShowCtrlHoverAction extends EditorAction {
class ShowDefinitionPreviewHoverAction extends EditorAction {

constructor() {
super({
id: 'editor.action.showCtrlHover',
id: 'editor.action.showDefinitionPreviewHover',
label: nls.localize({
key: 'showCtrlHover',
key: 'showDefinitionPreviewHover',
comment: [
'Label for action that will trigger the showing of a ctrl+hover in the editor.',
'This allows for users to show the ctrl+hover without using the mouse.'
'Label for action that will trigger the showing of definition preview hover in the editor.',
'This allows for users to show the definition preview hover without using the mouse.'
]
}, "Show Control Hover"),
alias: 'Show Control Hover',
}, "Show Definition Preview Hover"),
alias: 'Show Definition Preview Hover',
precondition: undefined
});
}
Expand Down Expand Up @@ -302,7 +302,7 @@ class ShowCtrlHoverAction extends EditorAction {

registerEditorContribution(ModesHoverController.ID, ModesHoverController);
registerEditorAction(ShowHoverAction);
registerEditorAction(ShowCtrlHoverAction);
registerEditorAction(ShowDefinitionPreviewHoverAction);

// theming
registerThemingParticipant((theme, collector) => {
Expand Down