Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom editors in the workbench #84672

Closed
6 tasks done
bpasero opened this issue Nov 13, 2019 · 4 comments
Closed
6 tasks done

Support for custom editors in the workbench #84672

bpasero opened this issue Nov 13, 2019 · 4 comments
Assignees
Labels
custom-editors Custom editor API (webview based editors) plan-item VS Code - planned item for upcoming
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Nov 13, 2019

To support custom editors (#77131, #12176) we need our IWorkingCopyService to become more powerful, specifically taking over responsibility of:

Work Areas:

  • dirty tracking
  • save/revert
  • auto save
  • hot exit
  • structural changes (move, delete, create, copy)
  • save participants (text file based only, we do not plan for an API for other extensions to modify the custom editor data)
@bpasero bpasero added the debt Code quality issues label Nov 13, 2019
@bpasero bpasero added this to the November 2019 milestone Nov 13, 2019
@bpasero bpasero self-assigned this Nov 13, 2019
@bpasero bpasero changed the title Implement and adopt working copy service Support for custom editors in the workbench Nov 17, 2019
@bpasero
Copy link
Member Author

bpasero commented Nov 18, 2019

I think we settled on saving everything, even working copies from custom editors.

@DonJayamanne
Copy link
Contributor

@bpasero @mjbvz Is the plan to (try) ship the custom editor in the next release?
I'd like to ensure we (Python Extension) uses this when its available.

@mjbvz
Copy link
Contributor

mjbvz commented Nov 20, 2019

No. It will remain as proposed api in 1.41

@bpasero bpasero modified the milestones: November 2019, December 2019 Dec 5, 2019
@bpasero bpasero added plan-item VS Code - planned item for upcoming and removed debt Code quality issues labels Dec 5, 2019
@bpasero
Copy link
Member Author

bpasero commented Jan 10, 2020

All editor auto save functionality will now work for custom editors as well.

@bpasero bpasero modified the milestones: January 2020, February 2020 Jan 24, 2020
@bpasero bpasero added the custom-editors Custom editor API (webview based editors) label Feb 4, 2020
@bpasero bpasero closed this as completed Feb 18, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
custom-editors Custom editor API (webview based editors) plan-item VS Code - planned item for upcoming
Projects
None yet
Development

No branches or pull requests

3 participants