Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Lens using Octicon cannot be triggered #85007

Closed
jdneo opened this issue Nov 18, 2019 · 2 comments
Closed

Code Lens using Octicon cannot be triggered #85007

jdneo opened this issue Nov 18, 2019 · 2 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug code-lens verified Verification succeeded
Milestone
November 2019

Comments

@jdneo
Copy link
Member

jdneo commented Nov 18, 2019

  • VSCode Version: 1.40.1
  • OS Version: Windows 10

Steps to Reproduce:

  1. Add a Code Lens which only contains octicon, like $(check)
  2. Binding a command to that Code Lens
  3. The Code Lens cannot trigger the command when clicking on it.
@vscodebot
Copy link

vscodebot bot commented Nov 18, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@jdneo jdneo mentioned this issue Nov 18, 2019
Merged
@jrieken jrieken added code-lens bug Issue identified by VS Code Team member as probable bug labels Nov 18, 2019
@jrieken jrieken added this to the November 2019 milestone Nov 18, 2019
@jrieken
Copy link
Member

jrieken commented Nov 18, 2019

Not a regression but an oversight with #82062 - octicons/codicons are rendered as <span> and the code lens widgets checks for clicks on <a> elements

@mjbvz mjbvz added the verified Verification succeeded label Dec 4, 2019
vyu113 added a commit to vyu113/vscode that referenced this issue Dec 8, 2019
@vyu113
Code Lens using Octicon cannot be triggered microsoft#85007
ee06cf5
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug code-lens verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
3 participants
@jrieken @jdneo @mjbvz