Code Lens using Octicon cannot be triggered microsoft#85007

vyu113 · Dec 8, 2019 · ee06cf5 · ee06cf5
1 parent 5c8acf3
commit ee06cf5
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/src/vs/editor/contrib/codelens/codelensController.ts b/src/vs/editor/contrib/codelens/codelensController.ts
@@ -223,15 +223,22 @@ export class CodeLensContribution implements editorCommon.IEditorContribution {
 			}
 		}));
 		this._localToDispose.add(this._editor.onMouseUp(e => {
-
-			for (const lens of this._lenses) {
-				let command = lens.getCommand(target as HTMLLinkElement);
-				if (command) {
-					this._commandService.executeCommand(command.id, ...(command.arguments || [])).catch(err => this._notificationService.error(err));
-					break;
+			if (e.target.type !== editorBrowser.MouseTargetType.CONTENT_WIDGET) {
+				return;
+			}
+			let target = e.target.element;
+			if (target?.tagName === 'SPAN') {
+				target = target.parentElement;
+			}
+			if (target?.tagName === 'A') {
+				for (const lens of this._lenses) {
+					let command = lens.getCommand(target as HTMLLinkElement);
+					if (command) {
+						this._commandService.executeCommand(command.id, ...(command.arguments || [])).catch(err => this._notificationService.error(err));
+						break;
+					}
 				}
 			}
-
 		}));
 		scheduler.schedule();
 	}