Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git Extension: Commit interface should provide date and author name #88294

Closed
ole1986 opened this issue Jan 8, 2020 · 9 comments · Fixed by #89005
Closed

Git Extension: Commit interface should provide date and author name #88294

ole1986 opened this issue Jan 8, 2020 · 9 comments · Fixed by #89005
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Milestone
February 2020

Comments

@ole1986
Copy link

ole1986 commented Jan 8, 2020

It would be very useful to have commit date, author name, ... in the Commit interface when calling getCommit([...])

Something similar to this:

export interface Commit {
    readonly hash: string;
    readonly message: string;
    readonly parents: string[];
    readonly commitDate?: Date;
    readonly authorEmail?: string | undefined;
    readonly authorName?: string | undefined;

}
@vscodebot
Copy link

vscodebot bot commented Jan 8, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the git GIT issues label Jan 8, 2020
@joaomoreno
Copy link
Member

@ole1986 What exactly more do you require?

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Jan 15, 2020
@ole1986
Copy link
Author

ole1986 commented Jan 15, 2020

Commit date and author name as already mentioned in the interface definition

@joaomoreno
Copy link
Member

Cool, wanna contribute a PR?

@joaomoreno joaomoreno changed the title Git Extension: Commit interface should provide more info Git Extension: Commit interface should provide date and author name Jan 16, 2020
@joaomoreno joaomoreno added feature-request Request for new features or functionality good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities and removed info-needed Issue requires more information from poster labels Jan 16, 2020
@joaomoreno joaomoreno added this to the Backlog milestone Jan 16, 2020
@ole1986
Copy link
Author

ole1986 commented Jan 16, 2020

@joaomoreno I really would want to but do not know when I can arrange a PR due to less time unfortunately..

@almoghaimo
Copy link

I'd be interested in grabbing this issue.

@prithuu
Copy link

prithuu commented Jan 20, 2020

I'm interested in this issue too, Did u start working on that @almoghaimo ?

@alyona-egorova
Copy link

Hey, @almoghaimo, @Prithviraj001! Sorry, I already started to work on it too and almost ready (will prepare PR tmr I think)

zjysdhr pushed a commit to zjysdhr/vscode that referenced this issue Jan 21, 2020
Fix microsoft#88294 Add authorName and commitData in commit interface
5ef3822
@zjysdhr zjysdhr mentioned this issue Jan 21, 2020
Merged
@almoghaimo
Copy link

OK I did worked on it too but I wasn't sure how to test it, how did you test it? only by the test commands?

zjysdhr added a commit to zjysdhr/vscode that referenced this issue Jan 29, 2020
@zjysdhr
Fix microsoft#88294 Add commitData in commit interface
51b8bd5
@joaomoreno joaomoreno modified the milestones: Backlog, February 2020 Feb 18, 2020
joaomoreno added a commit that referenced this issue Feb 18, 2020
@joaomoreno
Merge pull request #89005 from zjysdhr/issue/88294
c77f8a8 
Fix #88294 Add commitData in commit interface
@ole1986 ole1986 mentioned this issue Feb 18, 2020
Open
alexdima added a commit that referenced this issue Feb 18, 2020
@alexdima
Revert "Fix #88294 Add commitData in commit interface"
aa70f38 
This reverts commit 51b8bd5.
joaomoreno added a commit that referenced this issue Feb 18, 2020
@joaomoreno
Revert "Revert "Fix #88294 Add commitData in commit interface""
fe884b3 
This reverts commit aa70f38.
@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Feb 24, 2020
@connor4312 connor4312 removed the verification-needed Verification of issue is requested label Feb 26, 2020
@connor4312 connor4312 added the verified Verification succeeded label Feb 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Projects
None yet
Milestone
February 2020
Development

Successfully merging a pull request may close this issue.

Fix #88294 Add commitData in commit interface zjysdhr/vscode
6 participants
@joaomoreno @connor4312 @ole1986 @alyona-egorova @almoghaimo @prithuu