Add common service for logging deprecated api usage #88585
Conversation
|
This change doesn't cover deprecations for methods such as The reason is that I do not know how to get the calling extension information info in the implementation code |
| this._telemetryShape = rpc.getProxy(extHostProtocol.MainContext.MainThreadTelemetry); | ||
| } | ||
|
|
||
| public report(apiId: string, extension: IExtensionDescription, migrationSuggestion: string): void { |
There was a problem hiding this comment.
Suggestion to use ExtensionIdentifier only
There was a problem hiding this comment.
We also want to log a warning message if the extension is in development mode. For that I believe it needs the full IExtensionDescription
|
For the tasks constructor, I could mark the task as having been created using deprecated api, then in the extHostTaskService when reading tasks use |
|
@alexr00 I think you may also run a problem getting access to the deprecation service inside the task constructor. If you know some way to workaround this, feel free to give it a try |
For microsoft#88391 Adds a new `ExtHostApiDeprecationService`. This service logs a warning and telemetry when a deprecated API is used. Updates some of the more simple deprecated apis to use this new service
mjbvz
force-pushed
the
api-deprecation
branch
from
019608a
to
e05fda1
Compare
For #88391
Adds a new
ExtHostApiDeprecationService. This service logs a warning and telemetry when a deprecated API is used.Updates some of the more simple deprecated apis to use this new service