Will-navigate event should forward to opener service

[joaomoreno]

Related to #89215

This makes it that attempts to navigate the page in VS Code just get forwarded to OpenerService.open calls. Eg. clicking something like <a href="https://github.com">this</a> will eventually call openerService.open('https://github.com').

This is useful in notifications, where we currently listen to click events, and empty view contents #89215.

@bpasero @jrieken @mjbvz Let me know your thoughts.

[jrieken]

idk - we are using "normal" link with a click listener in many other places and that seems to work just fine. I see two issues with this:

• a half baked adoption as other callers, e.g users of actionHandler?: IContentActionHandler; aren't updated by this change
• a dependency onto the main-process, meaning notification links won't work in the web companion

I'd suggest to stick to what we have been doing before or have "global" listener inside the renderer so that this isn't desktop-only

[joaomoreno]

The problem with the current approach is that we also need to handle keyboard Enter for keyboard accessibility. And we must handle clicks and Enters everywhere links might appear, over and over again. 😢

[bpasero]

Yeah for web we need a different solution, good point. I think finding consumers should be relatively easier going for the IOpenerService usage.

[joaomoreno]

I'm not going to hunt all consumers of opener service. If you think this isn't good enough, I can just use click and key down handlers and let this go, like everyone else.

[jrieken]

The problem with the current approach is that we also need to handle keyboard Enter for keyboard accessibility. And we must handle clicks and Enters everywhere links might appear, over and over again. 😢

Doesn't that make a case for a Link-widget which does all of that, e.g using the opener service and having a command registered and so

[joaomoreno]

OK, closing it up!

[joaomoreno]

@bpasero In case you'd like to adopt in Notifications: ac834c0#diff-9f5d19be21bb00b33fa612b5e0d42066R19

[bpasero]

@joaomoreno I can look into it. Can we move this helper to the opener service into a browser layer? I find its location in workbench odd, especially since we may want to use it from the editor too.

[joaomoreno]

@bpasero Something like this? 1ceefd1

[bpasero]

Yes, thanks!