Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asked to sign in whenever turning on sync #90924

Closed
Tyriar opened this issue Feb 18, 2020 · 4 comments
Closed

Asked to sign in whenever turning on sync #90924

Tyriar opened this issue Feb 18, 2020 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug settings-sync verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 18, 2020

Repro:

  • Turn on sync
  • Do sign in flow
  • Turn off sync
  • Turn on sync, I'm presented with the sign in window

Sync is separate to login, shouldn't the auth session be retained between turning off and turning on sync? Saw this a lot in UX study, people were confused why they kept having to sign in.

Note that we may want to sign out when clearing all the server data, but I don't think it makes sense when just turning off regularly.

@Tyriar Tyriar added settings-sync authentication Issues with the Authentication platform labels Feb 18, 2020
@RMacfarlane
Copy link
Contributor

Caused by #90867

I would also expect to stay signed in when turning off sync, especially as sign in may eventually be used by other things

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Feb 19, 2020
@sandy081
Copy link
Member

I changed the behaviour to sign out because I remember few of us expected to sign out (@joaomoreno @misolori ) when turned off sync.

I will revert it to what it is originally - do not sign out. I had this because of the reason that login and sync are independent. Some other feature might be still using the account.

@RMacfarlane currently sign out is a core command which I think should not be and hence removing it. Feel free to add it as a command in the extension.

@sandy081 sandy081 added this to the February 2020 milestone Feb 19, 2020
@sandy081 sandy081 removed the authentication Issues with the Authentication platform label Feb 19, 2020
@sandy081 sandy081 mentioned this issue Feb 19, 2020
9 tasks
@Tyriar
Copy link
Member Author

Tyriar commented Feb 19, 2020

@RMacfarlane currently sign out is a core command which I think should not be and hence removing it. Feel free to add it as a command in the extension.

Does this meant that every extension needs to create their own sign out? Shouldn't it be a core command with an account selector if there are multiple accounts? Created #90988 to follow this up

@sandy081
Copy link
Member

Not sure who provides this command, but definitely not part of settings sync.

@rebornix rebornix added the verified Verification succeeded label Feb 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug settings-sync verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants