Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enter shortcut#85850 #91315

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

blueworrybear
Copy link
Contributor

This PR fixes #85850 by adding a no-newline icon, which allows user starting / stopping recording enter key.

Besides, there is a save icon for user during recording enter key for saving the change.

Below is the link to demo video:

vscode-screen-shot

https://imgur.com/a/gtABnOK

@msftclas
Copy link

msftclas commented Feb 24, 2020

CLA assistant check
All CLA requirements met.

@sandy081 sandy081 self-requested a review February 25, 2020 17:46
@sandy081 sandy081 added the keybindings-editor Keybinding editor issues label Feb 25, 2020
@sandy081 sandy081 added this to the March 2020 milestone Feb 25, 2020
@Tyriar Tyriar modified the milestones: March 2020, April 2020 Apr 7, 2020
@sandy081 sandy081 removed this from the April 2020 milestone Nov 16, 2020
@joaomoreno joaomoreno changed the base branch from master to main February 15, 2021 08:51
@sandy081
Copy link
Member

@blueworrybear Apologies that I could not address this PR for long time. If you are still interested to fix the associated issue, please update your PR and make it ready for review. Thanks.

@sandy081 sandy081 requested review from ulugbekna and removed request for sandy081 January 16, 2024 15:02
@sandy081 sandy081 assigned ulugbekna and unassigned sandy081 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keybindings-editor Keybinding editor issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for setting enter as a keyboard shortcut through the UI
5 participants