Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list view item height programmatically #91594

Merged
merged 3 commits into from
Feb 28, 2020

Conversation

rebornix
Copy link
Member

This PR contains two changes to the List View as we discussed today @joaomoreno

  • updateElementHeight which can modify the size of a list item and rerender the view properly
  • triggerScrollFromMouseWheelEvent which can accept mouse wheel events from external sources and scroll accordingly

Like all other rendering methods in the List View, if the List View is in the middle of rendering, invoking another render() or updateElementHeight() might mess up the view. This is a convention shared by all List View users.

@rebornix rebornix added this to the March 2020 milestone Feb 26, 2020
@rebornix rebornix self-assigned this Feb 26, 2020
@rebornix
Copy link
Member Author

This PR will be merged after @joaomoreno reviews and only after the master is open for business.

Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just small changes suggested.

src/vs/base/browser/ui/list/listView.ts Outdated Show resolved Hide resolved
src/vs/base/browser/ui/list/listView.ts Outdated Show resolved Hide resolved
src/vs/base/browser/ui/list/listView.ts Outdated Show resolved Hide resolved
src/vs/base/browser/ui/list/listView.ts Outdated Show resolved Hide resolved
Co-Authored-By: João Moreno <joao.moreno@microsoft.com>
@rebornix
Copy link
Member Author

Love the code suggestion feature from GitHub ;)

@rebornix rebornix merged commit 63cb05e into master Feb 28, 2020
@rebornix rebornix deleted the rebornix/listview-item-heightchange branch February 28, 2020 18:39
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants