Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the UndoRedoService for CustomEditors #92408

Merged
merged 3 commits into from Mar 12, 2020
Merged

Use the UndoRedoService for CustomEditors #92408

merged 3 commits into from Mar 12, 2020

Commits on Mar 10, 2020

  1. Use the UndoRedoService for CustomEditors 

    For microsoft#90110

Changes custom editors (the ones not based on text) to use the UndoRedoService. This involved:

- Moving edit lifecycle back into the main process again (this is actually the bulk of the changes)
- Removing the `undo`/`redo` methods on  `CustomEditorModel`
- Using the undoRedoService to trigger undo/redo
    @mjbvz
    mjbvz committed Mar 10, 2020
    Copy the full SHA
    3c77894 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. Call removeElements

    @mjbvz
    mjbvz committed Mar 12, 2020
    Copy the full SHA
    5e2b818 View commit details
    Browse the repository at this point in the history

  2. Use proper label

    @mjbvz
    mjbvz committed Mar 12, 2020
    Copy the full SHA
    ba338af View commit details
    Browse the repository at this point in the history