Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery: 94775 #94879

Merged
merged 1 commit into from Apr 14, 2020
Merged

Recovery: 94775 #94879

merged 1 commit into from Apr 14, 2020

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Apr 10, 2020

This PR fixes #94775

@chrmarti please check if the change makes sense to you, if the input is hidden I simply register a key listener on the list itself to handle navigation with keyboard.

We used to do that in the old quick open world, somewhere here only when quick nav was enabled (= input box hidden):

https://github.com/microsoft/vscode/blob/release/1.43/src/vs/base/parts/quickopen/browser/quickOpenWidget.ts#L303-L327

@bpasero bpasero added this to the March 2020 Recovery milestone Apr 10, 2020
@bpasero bpasero requested a review from chrmarti April 10, 2020 08:02
@bpasero bpasero self-assigned this Apr 10, 2020
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

We'd have to update it if the input box's visibility can change while the QuickInput is already shown, but I understand that this is currently not the case.

@bpasero bpasero merged commit a2b8208 into release/1.44 Apr 14, 2020
@bpasero bpasero deleted the ben/94775 branch April 14, 2020 12:53
bpasero added a commit that referenced this pull request Apr 14, 2020
This reverts commit a2b8208.
bpasero added a commit that referenced this pull request Apr 14, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants