Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open a file using system default application #95403

Closed
wants to merge 4 commits into from

Conversation

yujunqin
Copy link

@yujunqin yujunqin commented Apr 16, 2020

This PR fixes #92689

I added a context menu entry to open up a file using the system default application and bind a short cut Shift+Alt+O.
This functionality is implemented using Electron's openItem API.
I have tested this functionality on Windows opening PDF files, mp3 files and docx files.

@msftclas
Copy link

msftclas commented Apr 16, 2020

CLA assistant check
All CLA requirements met.

@yujunqin yujunqin marked this pull request as ready for review April 16, 2020 05:09
@bpasero bpasero assigned isidorn and unassigned bpasero Apr 16, 2020
@isidorn
Copy link
Contributor

isidorn commented Apr 16, 2020

Thank you for this PR. However we would not like this Feature in VS Code main yet.
Idealy extensions should be able to do this. Not sure if there are node module that can help here and that extensions simply contribute commands to VS Code.

So far now will not merge this PR. In the future we might change this decision.
This PR also needs testing on Mac and Linux in case we decide to merge it later.

Thanks

@isidorn isidorn added this to the Backlog milestone Apr 16, 2020
@isidorn
Copy link
Contributor

isidorn commented Nov 5, 2020

As per my previous comment I am closing this PR as out of scope and outdated

@isidorn isidorn closed this Nov 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to open files with the OS's default application
4 participants