Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS: Add setting to prompt users about workspace tsdk #95566
TS: Add setting to prompt users about workspace tsdk #95566
Changes from all commits
187dbaf
05ed577
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also make sure the user is not prompted if typescript is installed locally but
typescript.tsdk
is not setThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It follows the desired behavior in local testing. The check to see whether the prompt should runs is checking for the tsdk setting in configuration here. The intent is that
promptUseWorkspaceTsdk
should never be called in situations where the user shouldn't be prompted. Confusingly,promptUseWorkspaceTsdk
reads the local version from theversionProvider
to get a reference to the instance ofTypeScriptVersion
.configuation.localTsdk
is a string, which isn't enough to set the new TS version AFAIK